Part 1 of repairing regressions to my old clang check plugins so Nico can

chrome/common/net/gaia/gaia_auth_consumer.h

Index: chrome/common/net/gaia/gaia_auth_consumer.h
diff --git a/chrome/common/net/gaia/gaia_auth_consumer.h b/chrome/common/net/gaia/gaia_auth_consumer.h
index d498e6c64ff7de3149a9c7ff024a0fe13cd552d5..4d6c37de8770add56d312c342beda4f1e9fa70b3 100644
--- a/chrome/common/net/gaia/gaia_auth_consumer.h
+++ b/chrome/common/net/gaia/gaia_auth_consumer.h
@@ -15,24 +15,14 @@ class GoogleServiceAuthError;
 class GaiaAuthConsumer {
  public:
   struct ClientLoginResult {
-    inline ClientLoginResult() : two_factor(false) {}

[Nico, 2011/01/27 03:55:17]

lol inline

but since it's mentioned explicitly, maybe add whoever added this as reviewer,
just in case

-    inline ClientLoginResult(const std::string& new_sid,
-                             const std::string& new_lsid,
-                             const std::string& new_token,
-                             const std::string& new_data)
-        : sid(new_sid),
-          lsid(new_lsid),
-          token(new_token),
-          data(new_data),
-          two_factor(false) {}
-
-    inline bool operator==(const ClientLoginResult &b) const {
-      return sid == b.sid &&
-             lsid == b.lsid &&
-             token == b.token &&
-             data == b.data &&
-             two_factor == b.two_factor;
-    }
+    ClientLoginResult();
+    ClientLoginResult(const std::string& new_sid,
+                      const std::string& new_lsid,
+                      const std::string& new_token,
+                      const std::string& new_data);
+    ~ClientLoginResult();
+
+    bool operator==(const ClientLoginResult &b) const;
 
     std::string sid;
     std::string lsid;