Part 1 of repairing regressions to my old clang check plugins so Nico can

chrome/common/child_process_host.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_CHILD_PROCESS_HOST_H_
 #define CHROME_COMMON_CHILD_PROCESS_HOST_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 40 matching lines @@
   // On failure, returns an empty FilePath.
   static FilePath GetChildPath(bool allow_self);
 
 #if defined(OS_WIN)
   // See comments in the cc file. This is a common hack needed for a process
   // hosting a sandboxed child process. Hence it lives in this file.
   static void PreCacheFont(LOGFONT font);
 #endif  // defined(OS_WIN)
 
   // IPC::Message::Sender implementation.
-  bool Send(IPC::Message* message);
+  virtual bool Send(IPC::Message* message);
 
  protected:
   ChildProcessHost();
 
   // Adds an IPC message filter.  A reference will be kept to the filter.
   void AddFilter(IPC::ChannelProxy::MessageFilter* filter);
 
   // Derived classes return true if it's ok to shut down the child process.
   virtual bool CanShutdown() = 0;
 
   // Send the shutdown message to the child process.
   // Does not check if CanShutdown is true.
   virtual void ForceShutdown();
 
   // Creates the IPC channel.  Returns true iff it succeeded.
   virtual bool CreateChannel();
 
   // Notifies us that an instance has been created on this child process.
   virtual void InstanceCreated();
 
   // IPC::Channel::Listener implementation:
-  virtual bool OnMessageReceived(const IPC::Message& msg) { return false; }

[Nico, 2011/01/27 03:55:17]

these two. i will stop repeating this question.

-  virtual void OnChannelConnected(int32 peer_pid) { }
-  virtual void OnChannelError() { }
+  virtual bool OnMessageReceived(const IPC::Message& msg);
+  virtual void OnChannelConnected(int32 peer_pid);
+  virtual void OnChannelError();
 
   bool opening_channel() { return opening_channel_; }
   const std::string& channel_id() { return channel_id_; }
   IPC::Channel* channel() { return channel_.get(); }
 
   // Called when the child process goes away.
   virtual void OnChildDied();
   // Notifies the derived class that we told the child process to kill itself.
-  virtual void ShutdownStarted() { }
+  virtual void ShutdownStarted();
   // Subclasses can implement specific notification methods.
-  virtual void Notify(NotificationType type) { }
+  virtual void Notify(NotificationType type);
 
  private:
   // By using an internal class as the IPC::Channel::Listener, we can intercept
   // OnMessageReceived/OnChannelConnected and do our own processing before
   // calling the subclass' implementation.
   class ListenerHook : public IPC::Channel::Listener {
    public:
     explicit ListenerHook(ChildProcessHost* host);
     virtual bool OnMessageReceived(const IPC::Message& msg);
     virtual void OnChannelConnected(int32 peer_pid);
@@ skipping 10 matching lines @@
 
   // Holds all the IPC message filters.  Since this object lives on the IO
   // thread, we don't have a IPC::ChannelProxy and so we manage filters
   // manually.
   std::vector<scoped_refptr<IPC::ChannelProxy::MessageFilter> > filters_;
 
   DISALLOW_COPY_AND_ASSIGN(ChildProcessHost);
 };
 
 #endif  // CHROME_COMMON_CHILD_PROCESS_HOST_H_