Part 1 of repairing regressions to my old clang check plugins so Nico can

chrome/browser/tab_contents/web_navigation_observer.h

Index: chrome/browser/tab_contents/web_navigation_observer.h
diff --git a/chrome/browser/tab_contents/web_navigation_observer.h b/chrome/browser/tab_contents/web_navigation_observer.h
index 1a9d16d6b229a1044b7286ae40a5280a8f6bfbf4..97f841183d7cdf83d6e6bb552137de56b1d9a208 100644
--- a/chrome/browser/tab_contents/web_navigation_observer.h
+++ b/chrome/browser/tab_contents/web_navigation_observer.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -27,7 +27,7 @@ class WebNavigationObserver : public IPC::Channel::Listener {
   virtual void DidStopLoading() { }
 
   // IPC::Channel::Listener implementation.
-  virtual bool OnMessageReceived(const IPC::Message& message) { return false; }

[Nico, 2011/01/27 03:55:17]

this looks harmless too?

[Elliot Glaysher, 2011/01/27 18:48:05]

See this code review for discussion between me and Peter:
http://codereview.chromium.org/5741001/

After doing that bit of measurement, I've adopted a policy of no non-empty
virtual methods (since most compilers have a common case for that) and check for
that in the plugin. There are probably a few cases where you are correct but I'm
now doing this for consistency so I can automate the check.  (though this is
probably not one of them since the derived class hierarchy here is wide instead
of deep.)

+  virtual bool OnMessageReceived(const IPC::Message& message);
 
 #if 0
   // For unifying with delegate...