Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1969)

Unified Diff: chrome/browser/sync/glue/session_model_associator.h

Issue 6366019: Part 1 of repairing regressions to my old clang check plugins so Nico can (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove Nico's changes that I patched in for testing. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/session_model_associator.h
diff --git a/chrome/browser/sync/glue/session_model_associator.h b/chrome/browser/sync/glue/session_model_associator.h
index cff376feea4f6a2af7c2e6f8226eebca134b1d64..b6746cf3801584dd28396fdf03a7b4b9db39c15c 100644
--- a/chrome/browser/sync/glue/session_model_associator.h
+++ b/chrome/browser/sync/glue/session_model_associator.h
@@ -77,17 +77,11 @@ class SessionModelAssociator
virtual int64 GetSyncIdFromSessionTag(const std::string& tag);
// Not used.
- virtual const TabContents* GetChromeNodeFromSyncId(int64 sync_id) {
- NOTREACHED();
- return NULL;
- }
+ virtual const TabContents* GetChromeNodeFromSyncId(int64 sync_id);
// Not used.
- bool InitSyncNodeFromChromeId(const size_t& id,
- sync_api::BaseNode* sync_node) {
- NOTREACHED();
- return false;
- }
+ virtual bool InitSyncNodeFromChromeId(const size_t& id,
+ sync_api::BaseNode* sync_node);
// Resync local window information. Updates the local sessions header node
// with the status of open windows and the order of tabs they contain. Should
@@ -224,6 +218,7 @@ class SessionModelAssociator
class TabNodePool {
public:
explicit TabNodePool(ProfileSyncService* sync_service);
+ ~TabNodePool();
// Add a previously allocated tab sync node to our pool. Increases the size
// of tab_syncid_pool_ by one and marks the new tab node as free.

Powered by Google App Engine
This is Rietveld 408576698