Part 1 of repairing regressions to my old clang check plugins so Nico can

chrome/browser/sync/glue/session_model_associator.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_SESSION_MODEL_ASSOCIATOR_H_
 #define CHROME_BROWSER_SYNC_GLUE_SESSION_MODEL_ASSOCIATOR_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 59 matching lines @@
   // Returns sync_api::kInvalidId if the sync node is not found for the given
   // chrome id.
   virtual int64 GetSyncIdFromChromeId(const size_t& id);
 
   // Returns sync id for the given session tag.
   // Returns sync_api::kInvalidId if the sync node is not found for the given
   // tag
   virtual int64 GetSyncIdFromSessionTag(const std::string& tag);
 
   // Not used.
-  virtual const TabContents* GetChromeNodeFromSyncId(int64 sync_id) {
-    NOTREACHED();
-    return NULL;
-  }
+  virtual const TabContents* GetChromeNodeFromSyncId(int64 sync_id);
 
   // Not used.
-  bool InitSyncNodeFromChromeId(const size_t& id,
-                                sync_api::BaseNode* sync_node) {
-    NOTREACHED();
-    return false;
-  }
+  virtual bool InitSyncNodeFromChromeId(const size_t& id,
+                                        sync_api::BaseNode* sync_node);
 
   // Resync local window information. Updates the local sessions header node
   // with the status of open windows and the order of tabs they contain. Should
   // only be called for changes that affect a window, not a change within a
   // single tab.
   //
   // If |reload_tabs| is true, will also resync all tabs (same as calling
   // ReassociateTabs with a vector of all tabs).
   void ReassociateWindows(bool reload_tabs);
 
@@ skipping 116 matching lines @@
     int64 sync_id_;
     SessionTab* session_tab_;
     TabContents* tab_;
   };
 
   // A pool for managing free/used tab sync nodes. Performs lazy creation
   // of sync nodes when necessary.
   class TabNodePool {
    public:
     explicit TabNodePool(ProfileSyncService* sync_service);
+    ~TabNodePool();
 
     // Add a previously allocated tab sync node to our pool. Increases the size
     // of tab_syncid_pool_ by one and marks the new tab node as free.
     // Note: this should only be called when we discover tab sync nodes from
     // previous sessions, not for freeing tab nodes we created through
     // GetFreeTabNode (use FreeTabNode below for that).
     void AddTabNode(int64 sync_id);
 
     // Returns the sync_id for the next free tab node. If none are available,
     // creates a new tab node.
@@ skipping 167 matching lines @@
 
   // Consumer used to obtain the current session.
   CancelableRequestConsumer consumer_;
 
   DISALLOW_COPY_AND_ASSIGN(SessionModelAssociator);
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_SESSION_MODEL_ASSOCIATOR_H_