chrome/browser/debugger/inspectable_tab_proxy.h - Issue 6366019: Part 1 of repairing regressions to my old clang check plugins so Nico can

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/debugger/inspectable_tab_proxy.h

Issue 6366019: Part 1 of repairing regressions to my old clang check plugins so Nico can (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove Nico's changes that I patched in for testing. Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browsing_data_indexed_db_helper.h ('K') | « chrome/browser/browsing_data_indexed_db_helper.cc ('k') | chrome/browser/sync/engine/syncer_thread2.h » ('j') | chrome/browser/tab_contents/web_navigation_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/debugger/inspectable_tab_proxy.h

diff --git a/chrome/browser/debugger/inspectable_tab_proxy.h b/chrome/browser/debugger/inspectable_tab_proxy.h

index 48e8216a7a2527159c0d147fdf6c7a0f35921bd6..d07e96e507b91369144c6f176449bf50d9fbfe77 100644

--- a/chrome/browser/debugger/inspectable_tab_proxy.h

+++ b/chrome/browser/debugger/inspectable_tab_proxy.h

@@ -80,7 +80,7 @@ class DevToolsClientHostImpl : public DevToolsClientHost {

private:

// Message handling routines

void OnDebuggerOutput(const std::string& msg);

- void FrameNavigating(const std::string& url);

+ virtual void FrameNavigating(const std::string& url);

Nico 2011/01/27 03:55:17 OVERRIDE? :-P (requires base/compiler_specific.h)

void TabClosed();

int32 id_;