Refactor WebGraphicsContext3D to use WGC3D types which match corresponding GL...

Refactor WebGraphicsContext3D to use WGC3D types which match corresponding GL types.
BUG=none
TEST=compiled fine


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72807

[Zhenyao Mo, 2011-01-26 18:26:44]

Forget to mention, this CL build and run WebGL fine both with and without
USE_WGC3D_TYPES set on the webkit side.

On 2011/01/26 02:21:42, Zhenyao Mo wrote:

[Ken Russell (switch to Gerrit), 2011-01-26 23:58:02]

LGTM aside from these comments. Also please sync to TOT and incorporate the new
GL_CHROMIUM_framebuffer_blit entry points. Thanks.

http://codereview.chromium.org/6350016/diff/6001/chrome/renderer/webgraphicsc...
File chrome/renderer/webgraphicscontext3d_command_buffer_impl.h (right):

http://codereview.chromium.org/6350016/diff/6001/chrome/renderer/webgraphicsc...
chrome/renderer/webgraphicscontext3d_command_buffer_impl.h:43: using
WebKit::WGC3Dsizeiptr;
I think this block should go inside the #if defined(USE_WGC3D_TYPES) block for
safety. Not sure what happens if you have "using" directives for unknown types.

http://codereview.chromium.org/6350016/diff/6001/webkit/gpu/webgraphicscontex...
File webkit/gpu/webgraphicscontext3d_in_process_impl.cc (right):

http://codereview.chromium.org/6350016/diff/6001/webkit/gpu/webgraphicscontex...
webkit/gpu/webgraphicscontext3d_in_process_impl.cc:2867: break;
Looks like you need to sync to TOT.

http://codereview.chromium.org/6350016/diff/6001/webkit/gpu/webgraphicscontex...
File webkit/gpu/webgraphicscontext3d_in_process_impl.h (right):

http://codereview.chromium.org/6350016/diff/6001/webkit/gpu/webgraphicscontex...
webkit/gpu/webgraphicscontext3d_in_process_impl.h:34: using
WebKit::WGC3Dsizeiptr;
The block above should I think be guarded by #if defined(USE_WGC3D_TYPES) for
safety.