Refactor PPAPI proxy resource handling to maintain which host they came from,...

Refactor PPAPI proxy resource handling to maintain which host they came from,
and to map back to that host when calling functions on them. Adds a mapping
between resources generated by the hosts to a new list inside the plugin so
there can't be overlaps.

This means there are now two meanings for a PP_Resource, one in the plugin
process and one in the host process. This is potentially very confusing. I
introduced a new object called a HostResource that always represents a
"host" PP_Resource to try to prevent errors. In the plugin side of the proxy,
it only deals with PP_Resources valid in the plugin, and SerializedResources
valid in the host. It also encapsulates the associated instance, which
simplifies some code.

Each PluginResource object maintains its SerializedResource which the proxy
uses to send to the host for requests. This requires getting the PluginResource
object in more proxy calls.

This fixes a bug in var sending introduced in my previous patch. The var
releasing from EndSendPassRef used the host var rather than the plugin var. I
had to add more plumbing to get the dispatcher at this location and convert
to a plugin var.

I removed the separate file for ImageData and put it in ppb_image_data_proxy
like for the other resource types.

TEST=some unit tests included
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72879

[viettrungluu, 2011-01-27 16:52:57]

LG[*] with a few nits.

[*] Well, I'm just rubberstamping the boilerplate changes....

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/dispatcher.h
File ppapi/proxy/dispatcher.h (right):

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/dispatcher.h#ne...
ppapi/proxy/dispatcher.h:69: // Alternative to Init() for unit tests that want
to send all messages sent
Alternative to InitWithChannel()?

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/image_data.h
File ppapi/proxy/image_data.h (right):

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/image_data.h#ne...
ppapi/proxy/image_data.h:22: SerializedResource resource,
This sort of use makes me think that SerializedResource should also include the
PP_Instance (and perhaps be called "HostResource" instead).

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/plugin_resource.h
File ppapi/proxy/plugin_resource.h (right):

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/plugin_resource...
ppapi/proxy/plugin_resource.h:72: // The resource ID of the host that this
object corresponds to. Inside the
I think s/of/in/ would be clearer. (Some people would tell you to write "... to
which this object corresponds", but they're wrong.)

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/plugin_resource...
File ppapi/proxy/plugin_resource_tracker.cc (right):

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/plugin_resource...
ppapi/proxy/plugin_resource_tracker.cc:20: PluginResourceTracker*
resource_tracker_override = NULL;
Shouldn't its name be "g_..."?

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/plugin_resource...
File ppapi/proxy/plugin_resource_tracker.h (right):

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/plugin_resource...
ppapi/proxy/plugin_resource_tracker.h:8: #include <utility>
Nit: alphabetical order.

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/ppapi_param_tra...
File ppapi/proxy/ppapi_param_traits.h (right):

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/ppapi_param_tra...
ppapi/proxy/ppapi_param_traits.h:14: #include "ppapi/proxy/serialized_var.h" //
TODO(brettw) eraseme.
Why is this still here?

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/ppapi_proxy_test.h
File ppapi/proxy/ppapi_proxy_test.h (right):

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/ppapi_proxy_tes...
ppapi/proxy/ppapi_proxy_test.h:47: 
Nit: trailing blank line.

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/serialized_reso...
File ppapi/proxy/serialized_resource.h (right):

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/serialized_reso...
ppapi/proxy/serialized_resource.h:16: // hosts. It all values were PP_Resource,
it would be easy to forget to do
s/It/If/

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/serialized_reso...
ppapi/proxy/serialized_resource.h:19: // All SerializedResources respresent the
IDs valid in the host.
s/respresent/represent/

Also, I think the (first) "the" is unnecessary/confusing.

http://codereview.chromium.org/6334016/diff/36003/ppapi/proxy/serialized_reso...
ppapi/proxy/serialized_resource.h:32: // DO NOT CALL THESE FUNCTIONS IN THE
PLUGIN. The values will be invalid. See
By "PLUGIN", you mean "PLUGIN PROCESS" (or "PLUGIN-SIDE OF THE PROXY"), right?
-- the plugin itself never sees SerializedResource objects, no?

[brettw, 2011-01-27 18:41:20]

I did your suggestion for SerializedResource including an instance and renamed
it to be HostResource. This simplified some code.

I also deleted the separate file for image_data.* and folded it into the
corresponding proxy for consistency with the other resources.

Please take another look.

[viettrungluu, 2011-01-27 20:16:30]

Okay, everything LGTM (other than an indentation nit), assuming green-ish
trybots, etc.

http://codereview.chromium.org/6334016/diff/118005/ppapi/proxy/ppapi_param_tr...
File ppapi/proxy/ppapi_param_traits.cc (right):

http://codereview.chromium.org/6334016/diff/118005/ppapi/proxy/ppapi_param_tr...
ppapi/proxy/ppapi_param_traits.cc:414: const param_type& p) {
Nit: indentation. (And elsewhere in this file.)