Refactor PPAPI proxy resource handling to maintain which host they came from,...

ppapi/proxy/ppb_testing_proxy.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppb_testing_proxy.h"
 
 #include "base/message_loop.h"
 #include "ppapi/c/dev/ppb_testing_dev.h"
-#include "ppapi/proxy/image_data.h"
 #include "ppapi/proxy/plugin_dispatcher.h"
+#include "ppapi/proxy/plugin_resource.h"
+#include "ppapi/proxy/plugin_resource_tracker.h"
 #include "ppapi/proxy/ppapi_messages.h"
 
 namespace pp {
 namespace proxy {
 
 namespace {
 
-PP_Bool ReadImageData(PP_Resource device_context_2d,
+PP_Bool ReadImageData(PP_Resource graphics_2d,
                       PP_Resource image,
                       const PP_Point* top_left) {
-  ImageData* image_object = PluginResource::GetAs<ImageData>(image);
+  PluginResource* image_object = PluginResourceTracker::GetInstance()->
+      GetResourceObject(image);
   if (!image_object)
     return PP_FALSE;
+  PluginResource* graphics_2d_object =
+      PluginResourceTracker::GetInstance()->GetResourceObject(graphics_2d);
+  if (!graphics_2d_object ||
+      image_object->instance() != graphics_2d_object->instance())
+    return PP_FALSE;
+
   PluginDispatcher* dispatcher = PluginDispatcher::GetForInstance(
       image_object->instance());
   if (!dispatcher)
     return PP_FALSE;
 
   PP_Bool result = PP_FALSE;
   dispatcher->Send(new PpapiHostMsg_PPBTesting_ReadImageData(
-      INTERFACE_ID_PPB_TESTING, device_context_2d, image, *top_left, &result));
+      INTERFACE_ID_PPB_TESTING, graphics_2d_object->host_resource(),
+      image_object->host_resource(), *top_left, &result));
   return result;
 }
 
 void RunMessageLoop() {
   bool old_state = MessageLoop::current()->NestableTasksAllowed();
   MessageLoop::current()->SetNestableTasksAllowed(true);
   MessageLoop::current()->Run();
   MessageLoop::current()->SetNestableTasksAllowed(old_state);
 }
 
@@ skipping 46 matching lines @@
                         OnMsgRunMessageLoop)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBTesting_QuitMessageLoop,
                         OnMsgQuitMessageLoop)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_PPBTesting_GetLiveObjectsForInstance,
                         OnMsgGetLiveObjectsForInstance)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
-void PPB_Testing_Proxy::OnMsgReadImageData(PP_Resource device_context_2d,
-                                           PP_Resource image,
-                                           const PP_Point& top_left,
-                                           PP_Bool* result) {
+void PPB_Testing_Proxy::OnMsgReadImageData(
+    const HostResource& device_context_2d,
+    const HostResource& image,
+    const PP_Point& top_left,
+    PP_Bool* result) {
   *result = ppb_testing_target()->ReadImageData(
-      device_context_2d, image, &top_left);
+      device_context_2d.host_resource(), image.host_resource(), &top_left);
 }
 
 void PPB_Testing_Proxy::OnMsgRunMessageLoop(bool* dummy) {
   ppb_testing_target()->RunMessageLoop();
   *dummy = false;
 }
 
 void PPB_Testing_Proxy::OnMsgQuitMessageLoop() {
   ppb_testing_target()->QuitMessageLoop();
 }
 
 void PPB_Testing_Proxy::OnMsgGetLiveObjectsForInstance(PP_Instance instance,
-                                                uint32_t* result) {
+                                                       uint32_t* result) {
   *result = ppb_testing_target()->GetLiveObjectsForInstance(instance);
 }
 
 }  // namespace proxy
 }  // namespace pp