Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Unified Diff: ppapi/proxy/ppb_audio_proxy.h

Issue 6334016: Refactor PPAPI proxy resource handling to maintain which host they came from,... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/ppb_audio_config_proxy.cc ('k') | ppapi/proxy/ppb_audio_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppb_audio_proxy.h
===================================================================
--- ppapi/proxy/ppb_audio_proxy.h (revision 72840)
+++ ppapi/proxy/ppb_audio_proxy.h (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -21,6 +21,9 @@
namespace pp {
namespace proxy {
+struct PPBAudio_NotifyAudioStreamCreated_Params;
+class HostResource;
+
class PPB_Audio_Proxy : public InterfaceProxy {
public:
PPB_Audio_Proxy(Dispatcher* dispatcher, const void* target_interface);
@@ -38,19 +41,16 @@
private:
// Plugin->renderer message handlers.
void OnMsgCreate(PP_Instance instance_id,
- PP_Resource config_id,
- PP_Resource* result);
- void OnMsgStartOrStop(PP_Resource audio_id, bool play);
+ const HostResource& config_id,
+ HostResource* result);
+ void OnMsgStartOrStop(const HostResource& audio_id, bool play);
// Renderer->plugin message handlers.
void OnMsgNotifyAudioStreamCreated(
- PP_Resource audio_id,
- int32_t result_code,
- IPC::PlatformFileForTransit socket_handle,
- base::SharedMemoryHandle shared_memory_handle,
- uint32_t shared_memory_length);
+ const PPBAudio_NotifyAudioStreamCreated_Params& params);
- void AudioChannelConnected(int32_t result, PP_Resource resource);
+ void AudioChannelConnected(int32_t result,
+ const HostResource& resource);
// In the renderer, this is called in response to a stream created message.
// It will retrieve the shared memory and socket handles and place them into
@@ -61,7 +61,7 @@
// arguments may be written to, and others may be untouched, depending on
// where the error occurred.
int32_t GetAudioConnectedHandles(
- PP_Resource resource,
+ const HostResource& resource,
IPC::PlatformFileForTransit* foreign_socket_handle,
base::SharedMemoryHandle* foreign_shared_memory_handle,
uint32_t* shared_memory_length);
« no previous file with comments | « ppapi/proxy/ppb_audio_config_proxy.cc ('k') | ppapi/proxy/ppb_audio_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698