Refactor PPAPI proxy resource handling to maintain which host they came from,...

ppapi/proxy/ppapi_param_traits.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppapi_param_traits.h"
 
 #include <string.h>  // For memcpy
 
 #include "ppapi/c/dev/pp_file_info_dev.h"
 #include "ppapi/c/pp_resource.h"
+#include "ppapi/proxy/host_resource.h"
 #include "ppapi/proxy/interface_proxy.h"
 #include "ppapi/proxy/ppapi_messages.h"
 #include "ppapi/proxy/serialized_var.h"
 
 namespace IPC {
 
 // PP_Bool ---------------------------------------------------------------------
 
 // static
 void ParamTraits<PP_Bool>::Write(Message* m, const param_type& p) {
@@ skipping 152 matching lines @@
 
 // static
 bool ParamTraits<PP_Size>::Read(const Message* m, void** iter, param_type* r) {
   return m->ReadInt(iter, &r->width) && m->ReadInt(iter, &r->height);
 }
 
 // static
 void ParamTraits<PP_Size>::Log(const param_type& p, std::string* l) {
 }
 
+// PPBAudio_NotifyAudioStreamCreated_Params ------------------------------------
+
+// static
+void ParamTraits<pp::proxy::PPBAudio_NotifyAudioStreamCreated_Params>::Write(
+    Message* m,
+    const param_type& p) {
+  ParamTraits<PP_Instance>::Write(m, p.instance);
+  ParamTraits<pp::proxy::HostResource>::Write(m, p.audio_id);
+  ParamTraits<int32_t>::Write(m, p.result_code);
+  ParamTraits<PlatformFileForTransit>::Write(m, p.socket_handle);
+  ParamTraits<int32_t>::Write(m, p.length);
+}
+
+// static
+bool ParamTraits<pp::proxy::PPBAudio_NotifyAudioStreamCreated_Params>::Read(
+    const Message* m,
+    void** iter,
+    param_type* r) {
+  return
+      ParamTraits<PP_Instance>::Read(m, iter, &r->instance) &&
+      ParamTraits<pp::proxy::HostResource>::Read(m, iter, &r->audio_id) &&
+      ParamTraits<int32_t>::Read(m, iter, &r->result_code) &&
+      ParamTraits<PlatformFileForTransit>::Read(m, iter, &r->socket_handle) &&
+      ParamTraits<int32_t>::Read(m, iter, &r->length);
+}
+
+// static
+void ParamTraits<pp::proxy::PPBAudio_NotifyAudioStreamCreated_Params>::Log(
+    const param_type& p,
+    std::string* l) {
+}
+
 // PPBFlash_DrawGlyphs_Params --------------------------------------------------
 
 // static
 void ParamTraits<pp::proxy::PPBFlash_DrawGlyphs_Params>::Write(
     Message* m,
     const param_type& p) {
   ParamTraits<PP_Instance>::Write(m, p.instance);
-  ParamTraits<PP_Resource>::Write(m, p.pp_image_data);
+  ParamTraits<pp::proxy::HostResource>::Write(m, p.image_data);
   ParamTraits<pp::proxy::SerializedFontDescription>::Write(m, p.font_desc);
   ParamTraits<uint32_t>::Write(m, p.color);
   ParamTraits<PP_Point>::Write(m, p.position);
   ParamTraits<PP_Rect>::Write(m, p.clip);
   ParamTraits<float>::Write(m, p.transformation[0][0]);
   ParamTraits<float>::Write(m, p.transformation[0][1]);
   ParamTraits<float>::Write(m, p.transformation[0][2]);
   ParamTraits<float>::Write(m, p.transformation[1][0]);
   ParamTraits<float>::Write(m, p.transformation[1][1]);
   ParamTraits<float>::Write(m, p.transformation[1][2]);
   ParamTraits<float>::Write(m, p.transformation[2][0]);
   ParamTraits<float>::Write(m, p.transformation[2][1]);
   ParamTraits<float>::Write(m, p.transformation[2][2]);
   ParamTraits<std::vector<uint16_t> >::Write(m, p.glyph_indices);
   ParamTraits<std::vector<PP_Point> >::Write(m, p.glyph_advances);
 }
 
 // static
 bool ParamTraits<pp::proxy::PPBFlash_DrawGlyphs_Params>::Read(
     const Message* m,
     void** iter,
     param_type* r) {
   return
       ParamTraits<PP_Instance>::Read(m, iter, &r->instance) &&
-      ParamTraits<PP_Resource>::Read(m, iter, &r->pp_image_data) &&
+      ParamTraits<pp::proxy::HostResource>::Read(m, iter,
+                                                       &r->image_data) &&
       ParamTraits<pp::proxy::SerializedFontDescription>::Read(m, iter,
                                                               &r->font_desc) &&
       ParamTraits<uint32_t>::Read(m, iter, &r->color) &&
       ParamTraits<PP_Point>::Read(m, iter, &r->position) &&
       ParamTraits<PP_Rect>::Read(m, iter, &r->clip) &&
       ParamTraits<float>::Read(m, iter, &r->transformation[0][0]) &&
       ParamTraits<float>::Read(m, iter, &r->transformation[0][1]) &&
       ParamTraits<float>::Read(m, iter, &r->transformation[0][2]) &&
       ParamTraits<float>::Read(m, iter, &r->transformation[1][0]) &&
       ParamTraits<float>::Read(m, iter, &r->transformation[1][1]) &&
@@ skipping 11 matching lines @@
     const param_type& p,
     std::string* l) {
 }
 
 // PPBFont_DrawTextAt_Params ---------------------------------------------------
 
 // static
 void ParamTraits<pp::proxy::PPBFont_DrawTextAt_Params>::Write(
     Message* m,
     const param_type& p) {
-  ParamTraits<PP_Resource>::Write(m, p.font);
-  ParamTraits<PP_Resource>::Write(m, p.image_data);
+  ParamTraits<pp::proxy::HostResource>::Write(m, p.font);
+  ParamTraits<pp::proxy::HostResource>::Write(m, p.image_data);
   ParamTraits<PP_Bool>::Write(m, p.text_is_rtl);
   ParamTraits<PP_Bool>::Write(m, p.override_direction);
   ParamTraits<PP_Point>::Write(m, p.position);
   ParamTraits<uint32_t>::Write(m, p.color);
   ParamTraits<PP_Rect>::Write(m, p.clip);
   ParamTraits<bool>::Write(m, p.clip_is_null);
   ParamTraits<PP_Bool>::Write(m, p.image_data_is_opaque);
 }
 
 // static
 bool ParamTraits<pp::proxy::PPBFont_DrawTextAt_Params>::Read(
     const Message* m,
     void** iter,
     param_type* r) {
   return
-      ParamTraits<PP_Resource>::Read(m, iter, &r->font) &&
-      ParamTraits<PP_Resource>::Read(m, iter, &r->image_data) &&
+      ParamTraits<pp::proxy::HostResource>::Read(m, iter, &r->font) &&
+      ParamTraits<pp::proxy::HostResource>::Read(m, iter,
+                                                       &r->image_data) &&
       ParamTraits<PP_Bool>::Read(m, iter, &r->text_is_rtl) &&
       ParamTraits<PP_Bool>::Read(m, iter, &r->override_direction) &&
       ParamTraits<PP_Point>::Read(m, iter, &r->position) &&
       ParamTraits<uint32_t>::Read(m, iter, &r->color) &&
       ParamTraits<PP_Rect>::Read(m, iter, &r->clip) &&
       ParamTraits<bool>::Read(m, iter, &r->clip_is_null) &&
       ParamTraits<PP_Bool>::Read(m, iter, &r->image_data_is_opaque);
 }
 
 // static
 void ParamTraits<pp::proxy::PPBFont_DrawTextAt_Params>::Log(
     const param_type& p,
     std::string* l) {
 }
 
+// PPBURLLoader_UpdateProgress_Params ------------------------------------------
+
+// static
+void ParamTraits<pp::proxy::PPBURLLoader_UpdateProgress_Params>::Write(
+    Message* m,
+    const param_type& p) {
+  ParamTraits<PP_Instance>::Write(m, p.instance);
+  ParamTraits<pp::proxy::HostResource>::Write(m, p.resource);
+  ParamTraits<int64_t>::Write(m, p.bytes_sent);
+  ParamTraits<int64_t>::Write(m, p.total_bytes_to_be_sent);
+  ParamTraits<int64_t>::Write(m, p.bytes_received);
+  ParamTraits<int64_t>::Write(m, p.total_bytes_to_be_received);
+}
+
+// static
+bool ParamTraits<pp::proxy::PPBURLLoader_UpdateProgress_Params>::Read(
+    const Message* m,
+    void** iter,
+    param_type* r) {
+  return
+      ParamTraits<PP_Instance>::Read(m, iter, &r->instance) &&
+      ParamTraits<pp::proxy::HostResource>::Read(m, iter, &r->resource) &&
+      ParamTraits<int64_t>::Read(m, iter, &r->bytes_sent) &&
+      ParamTraits<int64_t>::Read(m, iter, &r->total_bytes_to_be_sent) &&
+      ParamTraits<int64_t>::Read(m, iter, &r->bytes_received) &&
+      ParamTraits<int64_t>::Read(m, iter, &r->total_bytes_to_be_received);
+}
+
+// static
+void ParamTraits<pp::proxy::PPBURLLoader_UpdateProgress_Params>::Log(
+    const param_type& p,
+    std::string* l) {
+}
+
 // SerializedDirEntry ----------------------------------------------------------
 
 // static
 void ParamTraits<pp::proxy::SerializedDirEntry>::Write(Message* m,
                                                        const param_type& p) {
   ParamTraits<std::string>::Write(m, p.name);
   ParamTraits<bool>::Write(m, p.is_dir);
 }
 
 // static
 bool ParamTraits<pp::proxy::SerializedDirEntry>::Read(const Message* m,
                                                       void** iter,
                                                       param_type* r) {
   return ParamTraits<std::string>::Read(m, iter, &r->name) &&
          ParamTraits<bool>::Read(m, iter, &r->is_dir);
 }
 
 // static
 void ParamTraits<pp::proxy::SerializedDirEntry>::Log(const param_type& p,
                                                      std::string* l) {
 }
 
-// SerializedVar ---------------------------------------------------------------
-
-// static
-void ParamTraits<pp::proxy::SerializedVar>::Write(Message* m,
-                                                  const param_type& p) {
-  p.WriteToMessage(m);
-}
-
-// static
-bool ParamTraits<pp::proxy::SerializedVar>::Read(const Message* m,
-                                                 void** iter,
-                                                 param_type* r) {
-  return r->ReadFromMessage(m, iter);
-}
-
-// static
-void ParamTraits<pp::proxy::SerializedVar>::Log(const param_type& p,
-                                                std::string* l) {
-}
-
 // pp::proxy::SerializedFontDescription ----------------------------------------
 
 // static
 void ParamTraits<pp::proxy::SerializedFontDescription>::Write(
     Message* m,
     const param_type& p) {
   ParamTraits<pp::proxy::SerializedVar>::Write(m, p.face);
   ParamTraits<int32_t>::Write(m, p.family);
   ParamTraits<uint32_t>::Write(m, p.size);
   ParamTraits<int32_t>::Write(m, p.weight);
@@ skipping 18 matching lines @@
       ParamTraits<int32_t>::Read(m, iter, &r->letter_spacing) &&
       ParamTraits<int32_t>::Read(m, iter, &r->word_spacing);
 }
 
 // static
 void ParamTraits<pp::proxy::SerializedFontDescription>::Log(
     const param_type& p,
     std::string* l) {
 }
 
+// HostResource ----------------------------------------------------------
+
+// static
+void ParamTraits<pp::proxy::HostResource>::Write(Message* m,
+                                                       const param_type& p) {

[viettrungluu, 2011/01/27 20:16:30]

Nit: indentation. (And elsewhere in this file.)

+  ParamTraits<PP_Instance>::Write(m, p.instance());
+  ParamTraits<PP_Resource>::Write(m, p.host_resource());
+}
+
+// static
+bool ParamTraits<pp::proxy::HostResource>::Read(const Message* m,
+                                                      void** iter,
+                                                      param_type* r) {
+  PP_Instance instance;
+  PP_Resource resource;
+  if (!ParamTraits<PP_Instance>::Read(m, iter, &instance) ||
+      !ParamTraits<PP_Resource>::Read(m, iter, &resource))
+    return false;
+  r->SetHostResource(instance, resource);
+  return true;
+}
+
+// static
+void ParamTraits<pp::proxy::HostResource>::Log(const param_type& p,
+                                                     std::string* l) {
+}
+
+// SerializedVar ---------------------------------------------------------------
+
+// static
+void ParamTraits<pp::proxy::SerializedVar>::Write(Message* m,
+                                                  const param_type& p) {
+  p.WriteToMessage(m);
+}
+
+// static
+bool ParamTraits<pp::proxy::SerializedVar>::Read(const Message* m,
+                                                 void** iter,
+                                                 param_type* r) {
+  return r->ReadFromMessage(m, iter);
+}
+
+// static
+void ParamTraits<pp::proxy::SerializedVar>::Log(const param_type& p,
+                                                std::string* l) {
+}
+
 // std::vector<SerializedVar> --------------------------------------------------
 
 void ParamTraits< std::vector<pp::proxy::SerializedVar> >::Write(
     Message* m,
     const param_type& p) {
   WriteParam(m, static_cast<int>(p.size()));
   for (size_t i = 0; i < p.size(); i++)
     WriteParam(m, p[i]);
 }
 
@@ skipping 36 matching lines @@
   return true;
 }
 
 // static
 void ParamTraits< std::vector<pp::proxy::SerializedVar> >::Log(
     const param_type& p,
     std::string* l) {
 }
 
 }  // namespace IPC