Issue 6293010: Change all the places where the multi-purpose sync error link is surfaced to ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6293010: Change all the places where the multi-purpose sync error link is surfaced to ... (Closed)

Created:
9 years, 11 months ago by John Gregg

Modified:
9 years ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, arv (Not doing code reviews), pam+watch_chromium.org, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Change all the places where the multi-purpose sync error link is surfaced to call a common routine that either shows a login prompt or shows the passphrase prompt depending on the reason for the error. BUG=68962 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71844

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -26 lines)			Patch
M	chrome/browser/dom_ui/new_tab_page_sync_handler.cc	View	1 chunk	+1 line, -20 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.css	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1 chunk	+19 lines, -0 lines	1 comment	Download
M	chrome/browser/ui/cocoa/options/preferences_window_controller.mm	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/bookmark_bar_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/options/content_page_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmark_bar_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/options/content_page_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

9 years, 11 months ago (2011-01-19 21:34:29 UTC) #2

LGTM

http://codereview.chromium.org/6293010/diff/1/chrome/browser/sync/profile_syn...
File chrome/browser/sync/profile_sync_service.cc (right):

http://codereview.chromium.org/6293010/diff/1/chrome/browser/sync/profile_syn...
chrome/browser/sync/profile_sync_service.cc:742: error.state() == 
GoogleServiceAuthError::SERVICE_UNAVAILABLE) {
nit - extra space after ==

Expand Messages | Collapse Messages