Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6192007: Remove wstring from views. Part 3: Switch accessibility strings to string16.... (Closed)

Created:
9 years, 11 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, evanm
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove wstring from views. Part 3: Switch accessibility strings to string16. BUG=68267 TEST=no visible changes; all tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71461

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -152 lines) Patch
M chrome/browser/chromeos/login/new_user_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/accessibility_event_router_views.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmark_bar_view.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/bookmark_bubble_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmark_editor_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container.cc View 1 3 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/clear_browsing_data.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/clear_browsing_data_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/clear_data_view.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/download_item_view.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/download_shelf_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_root_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 6 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/importer_view.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_container.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobars.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/options_group_view.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/options/options_window_view.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/base_tab.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 5 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
M views/accessibility/view_accessibility.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M views/controls/button/button.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M views/controls/button/button.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/button/button_dropdown.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M views/controls/button/button_dropdown.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/button/menu_button.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M views/controls/button/menu_button.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/button/native_button.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/button/native_button_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/button/text_button.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/combobox/combobox.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/combobox/combobox.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/image_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/label.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/label_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M views/controls/menu/menu_item_view.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/menu/submenu_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/progress_bar_unittest.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M views/controls/tabbed_pane/tabbed_pane.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M views/controls/textfield/native_textfield_win.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M views/controls/textfield/textfield.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M views/controls/textfield/textfield.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M views/view.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M views/view.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M views/window/custom_frame_view.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
9 years, 11 months ago (2011-01-11 19:44:29 UTC) #1
Avi (use Gerrit)
ping?
9 years, 11 months ago (2011-01-12 19:46:25 UTC) #2
Evan Martin
I am unclear whether accessible names are localized or not. http://codereview.chromium.org/6192007/diff/1/chrome/browser/ui/views/accessibility_event_router_views.cc File chrome/browser/ui/views/accessibility_event_router_views.cc (right): http://codereview.chromium.org/6192007/diff/1/chrome/browser/ui/views/accessibility_event_router_views.cc#newcode157 ...
9 years, 11 months ago (2011-01-12 20:00:51 UTC) #3
Evan Martin
looking now On Wed, Jan 12, 2011 at 11:46 AM, <avi@chromium.org> wrote: > ping? > ...
9 years, 11 months ago (2011-01-12 20:01:07 UTC) #4
Avi (use Gerrit)
http://codereview.chromium.org/6192007/diff/1/chrome/browser/ui/views/accessibility_event_router_views.cc File chrome/browser/ui/views/accessibility_event_router_views.cc (right): http://codereview.chromium.org/6192007/diff/1/chrome/browser/ui/views/accessibility_event_router_views.cc#newcode157 chrome/browser/ui/views/accessibility_event_router_views.cc:157: view->GetAccessibleName(&wname); Re Dominic's email, this sends the name to ...
9 years, 11 months ago (2011-01-13 01:03:03 UTC) #5
evanm
9 years, 11 months ago (2011-01-14 00:43:51 UTC) #6 
LGTM

Powered by Google App Engine
This is Rietveld 408576698