Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: chrome/browser/ui/views/browser_actions_container.cc

Issue 6192007: Remove wstring from views. Part 3: Switch accessibility strings to string16.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/bookmark_editor_view.cc ('k') | chrome/browser/ui/views/clear_browsing_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/browser_actions_container.cc
===================================================================
--- chrome/browser/ui/views/browser_actions_container.cc (revision 71358)
+++ chrome/browser/ui/views/browser_actions_container.cc (working copy)
@@ -165,10 +165,10 @@
}
// If the browser action name is empty, show the extension name instead.
- std::wstring name = UTF8ToWide(browser_action()->GetTitle(tab_id));
+ string16 name = UTF8ToUTF16(browser_action()->GetTitle(tab_id));
if (name.empty())
- name = UTF8ToWide(extension()->name());
- SetTooltipText(name);
+ name = UTF8ToUTF16(extension()->name());
+ SetTooltipText(UTF16ToWideHack(name));
SetAccessibleName(name);
GetParent()->SchedulePaint();
}
@@ -288,8 +288,8 @@
button_->SetDragController(panel_);
AddChildView(button_);
button_->UpdateState();
- SetAccessibleName(UTF16ToWide(
- l10n_util::GetStringUTF16(IDS_ACCNAME_EXTENSIONS_BROWSER_ACTION)));
+ SetAccessibleName(
+ l10n_util::GetStringUTF16(IDS_ACCNAME_EXTENSIONS_BROWSER_ACTION));
}
BrowserActionView::~BrowserActionView() {
@@ -369,19 +369,18 @@
resize_animation_.reset(new ui::SlideAnimation(this));
resize_area_ = new views::ResizeArea(this);
resize_area_->SetAccessibleName(
- UTF16ToWide(l10n_util::GetStringUTF16(IDS_ACCNAME_SEPARATOR)));
+ l10n_util::GetStringUTF16(IDS_ACCNAME_SEPARATOR));
AddChildView(resize_area_);
chevron_ = new views::MenuButton(NULL, std::wstring(), this, false);
chevron_->set_border(NULL);
chevron_->EnableCanvasFlippingForRTLUI(true);
chevron_->SetAccessibleName(
- UTF16ToWide(l10n_util::GetStringUTF16(IDS_ACCNAME_EXTENSIONS_CHEVRON)));
+ l10n_util::GetStringUTF16(IDS_ACCNAME_EXTENSIONS_CHEVRON));
chevron_->SetVisible(false);
AddChildView(chevron_);
- SetAccessibleName(
- UTF16ToWide(l10n_util::GetStringUTF16(IDS_ACCNAME_EXTENSIONS)));
+ SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_EXTENSIONS));
}
BrowserActionsContainer::~BrowserActionsContainer() {
« no previous file with comments | « chrome/browser/ui/views/bookmark_editor_view.cc ('k') | chrome/browser/ui/views/clear_browsing_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698