Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Side by Side Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 6192007: Remove wstring from views. Part 3: Switch accessibility strings to string16.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.cc ('k') | chrome/browser/ui/views/wrench_menu.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/toolbar_view.h" 5 #include "chrome/browser/ui/views/toolbar_view.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "app/resource_bundle.h" 8 #include "app/resource_bundle.h"
9 #include "base/i18n/number_formatting.h" 9 #include "base/i18n/number_formatting.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 } 146 }
147 #endif 147 #endif
148 back_ = new views::ButtonDropDown(this, back_menu_model_.get()); 148 back_ = new views::ButtonDropDown(this, back_menu_model_.get());
149 back_->set_triggerable_event_flags(views::Event::EF_LEFT_BUTTON_DOWN | 149 back_->set_triggerable_event_flags(views::Event::EF_LEFT_BUTTON_DOWN |
150 views::Event::EF_MIDDLE_BUTTON_DOWN); 150 views::Event::EF_MIDDLE_BUTTON_DOWN);
151 back_->set_tag(IDC_BACK); 151 back_->set_tag(IDC_BACK);
152 back_->SetImageAlignment(views::ImageButton::ALIGN_RIGHT, 152 back_->SetImageAlignment(views::ImageButton::ALIGN_RIGHT,
153 views::ImageButton::ALIGN_TOP); 153 views::ImageButton::ALIGN_TOP);
154 back_->SetTooltipText( 154 back_->SetTooltipText(
155 UTF16ToWide(l10n_util::GetStringUTF16(IDS_TOOLTIP_BACK))); 155 UTF16ToWide(l10n_util::GetStringUTF16(IDS_TOOLTIP_BACK)));
156 back_->SetAccessibleName( 156 back_->SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_BACK));
157 UTF16ToWide(l10n_util::GetStringUTF16(IDS_ACCNAME_BACK)));
158 back_->SetID(VIEW_ID_BACK_BUTTON); 157 back_->SetID(VIEW_ID_BACK_BUTTON);
159 158
160 forward_ = new views::ButtonDropDown(this, forward_menu_model_.get()); 159 forward_ = new views::ButtonDropDown(this, forward_menu_model_.get());
161 forward_->set_triggerable_event_flags(views::Event::EF_LEFT_BUTTON_DOWN | 160 forward_->set_triggerable_event_flags(views::Event::EF_LEFT_BUTTON_DOWN |
162 views::Event::EF_MIDDLE_BUTTON_DOWN); 161 views::Event::EF_MIDDLE_BUTTON_DOWN);
163 forward_->set_tag(IDC_FORWARD); 162 forward_->set_tag(IDC_FORWARD);
164 forward_->SetTooltipText( 163 forward_->SetTooltipText(
165 UTF16ToWide(l10n_util::GetStringUTF16(IDS_TOOLTIP_FORWARD))); 164 UTF16ToWide(l10n_util::GetStringUTF16(IDS_TOOLTIP_FORWARD)));
166 forward_->SetAccessibleName( 165 forward_->SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_FORWARD));
167 UTF16ToWide(l10n_util::GetStringUTF16(IDS_ACCNAME_FORWARD)));
168 forward_->SetID(VIEW_ID_FORWARD_BUTTON); 166 forward_->SetID(VIEW_ID_FORWARD_BUTTON);
169 167
170 // Have to create this before |reload_| as |reload_|'s constructor needs it. 168 // Have to create this before |reload_| as |reload_|'s constructor needs it.
171 location_bar_ = new LocationBarView(profile, browser_->command_updater(), 169 location_bar_ = new LocationBarView(profile, browser_->command_updater(),
172 model_, this, (display_mode_ == DISPLAYMODE_LOCATION) ? 170 model_, this, (display_mode_ == DISPLAYMODE_LOCATION) ?
173 LocationBarView::POPUP : LocationBarView::NORMAL); 171 LocationBarView::POPUP : LocationBarView::NORMAL);
174 172
175 reload_ = new ReloadButton(location_bar_, browser_); 173 reload_ = new ReloadButton(location_bar_, browser_);
176 reload_->set_triggerable_event_flags(views::Event::EF_LEFT_BUTTON_DOWN | 174 reload_->set_triggerable_event_flags(views::Event::EF_LEFT_BUTTON_DOWN |
177 views::Event::EF_MIDDLE_BUTTON_DOWN); 175 views::Event::EF_MIDDLE_BUTTON_DOWN);
178 reload_->set_tag(IDC_RELOAD); 176 reload_->set_tag(IDC_RELOAD);
179 reload_->SetTooltipText( 177 reload_->SetTooltipText(
180 UTF16ToWide(l10n_util::GetStringUTF16(IDS_TOOLTIP_RELOAD))); 178 UTF16ToWide(l10n_util::GetStringUTF16(IDS_TOOLTIP_RELOAD)));
181 reload_->SetAccessibleName( 179 reload_->SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_RELOAD));
182 UTF16ToWide(l10n_util::GetStringUTF16(IDS_ACCNAME_RELOAD)));
183 reload_->SetID(VIEW_ID_RELOAD_BUTTON); 180 reload_->SetID(VIEW_ID_RELOAD_BUTTON);
184 181
185 #if defined(OS_CHROMEOS) 182 #if defined(OS_CHROMEOS)
186 feedback_ = new views::ImageButton(this); 183 feedback_ = new views::ImageButton(this);
187 feedback_->set_tag(IDC_FEEDBACK); 184 feedback_->set_tag(IDC_FEEDBACK);
188 feedback_->set_triggerable_event_flags(views::Event::EF_LEFT_BUTTON_DOWN | 185 feedback_->set_triggerable_event_flags(views::Event::EF_LEFT_BUTTON_DOWN |
189 views::Event::EF_MIDDLE_BUTTON_DOWN); 186 views::Event::EF_MIDDLE_BUTTON_DOWN);
190 feedback_->set_tag(IDC_FEEDBACK); 187 feedback_->set_tag(IDC_FEEDBACK);
191 feedback_->SetTooltipText( 188 feedback_->SetTooltipText(
192 UTF16ToWide(l10n_util::GetStringUTF16(IDS_TOOLTIP_FEEDBACK))); 189 UTF16ToWide(l10n_util::GetStringUTF16(IDS_TOOLTIP_FEEDBACK)));
193 feedback_->SetID(VIEW_ID_FEEDBACK_BUTTON); 190 feedback_->SetID(VIEW_ID_FEEDBACK_BUTTON);
194 #endif 191 #endif
195 192
196 home_ = new views::ImageButton(this); 193 home_ = new views::ImageButton(this);
197 home_->set_triggerable_event_flags(views::Event::EF_LEFT_BUTTON_DOWN | 194 home_->set_triggerable_event_flags(views::Event::EF_LEFT_BUTTON_DOWN |
198 views::Event::EF_MIDDLE_BUTTON_DOWN); 195 views::Event::EF_MIDDLE_BUTTON_DOWN);
199 home_->set_tag(IDC_HOME); 196 home_->set_tag(IDC_HOME);
200 home_->SetTooltipText( 197 home_->SetTooltipText(
201 UTF16ToWide(l10n_util::GetStringUTF16(IDS_TOOLTIP_HOME))); 198 UTF16ToWide(l10n_util::GetStringUTF16(IDS_TOOLTIP_HOME)));
202 home_->SetAccessibleName( 199 home_->SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_HOME));
203 UTF16ToWide(l10n_util::GetStringUTF16(IDS_ACCNAME_HOME)));
204 home_->SetID(VIEW_ID_HOME_BUTTON); 200 home_->SetID(VIEW_ID_HOME_BUTTON);
205 201
206 browser_actions_ = new BrowserActionsContainer(browser_, this); 202 browser_actions_ = new BrowserActionsContainer(browser_, this);
207 203
208 app_menu_ = new views::MenuButton(NULL, std::wstring(), this, false); 204 app_menu_ = new views::MenuButton(NULL, std::wstring(), this, false);
209 app_menu_->set_border(NULL); 205 app_menu_->set_border(NULL);
210 app_menu_->EnableCanvasFlippingForRTLUI(true); 206 app_menu_->EnableCanvasFlippingForRTLUI(true);
211 app_menu_->SetAccessibleName( 207 app_menu_->SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_APP));
212 UTF16ToWide(l10n_util::GetStringUTF16(IDS_ACCNAME_APP)));
213 app_menu_->SetTooltipText(UTF16ToWide(l10n_util::GetStringFUTF16( 208 app_menu_->SetTooltipText(UTF16ToWide(l10n_util::GetStringFUTF16(
214 IDS_APPMENU_TOOLTIP, 209 IDS_APPMENU_TOOLTIP,
215 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME)))); 210 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME))));
216 app_menu_->SetID(VIEW_ID_APP_MENU); 211 app_menu_->SetID(VIEW_ID_APP_MENU);
217 212
218 // Add any necessary badges to the menu item based on the system state. 213 // Add any necessary badges to the menu item based on the system state.
219 if (IsUpgradeRecommended() || ShouldShowIncompatibilityWarning() || 214 if (IsUpgradeRecommended() || ShouldShowIncompatibilityWarning() ||
220 ShouldShowBackgroundPageBadge()) { 215 ShouldShowBackgroundPageBadge()) {
221 UpdateAppMenuBadge(); 216 UpdateAppMenuBadge();
222 } 217 }
(...skipping 548 matching lines...) Expand 10 before | Expand all | Expand 10 after
771 NOTREACHED(); 766 NOTREACHED();
772 #endif 767 #endif
773 } else { 768 } else {
774 NOTREACHED(); 769 NOTREACHED();
775 } 770 }
776 771
777 canvas->DrawBitmapInt(badge, icon.width() - badge.width(), kBadgeTopMargin); 772 canvas->DrawBitmapInt(badge, icon.width() - badge.width(), kBadgeTopMargin);
778 773
779 return canvas->ExtractBitmap(); 774 return canvas->ExtractBitmap();
780 } 775 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.cc ('k') | chrome/browser/ui/views/wrench_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698