Remove wstring from views. Part 3: Switch accessibility strings to string16....

chrome/browser/ui/views/accessibility_event_router_views.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/accessibility_event_router_views.h"
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
@@ skipping 135 matching lines @@
   std::string name;
 
   // First see if we have a name registered for this view.
   base::hash_map<views::View*, ViewInfo>::const_iterator iter =
       view_info_map_.find(view);
   if (iter != view_info_map_.end())
     name = iter->second.name;
 
   // Otherwise ask the view for its accessible name.
   if (name.empty()) {
-    std::wstring wname;
+    string16 wname;
     view->GetAccessibleName(&wname);

[Evan Martin, 2011/01/12 20:00:51]

It seems GetAccessibleName should be working with ASCII (?)

Or *this* function is wrong, to return a plain string

[Avi (use Gerrit), 2011/01/13 01:03:03]

Re Dominic's email, this sends the name to Javascript which requires UTF-8. I
stand by my CL.

-    name = WideToUTF8(wname);
+    name = UTF16ToUTF8(wname);
   }
 
   return name;
 }
 
 void AccessibilityEventRouterViews::DispatchAccessibilityNotification(
     views::View* view, NotificationType type) {
   Profile* profile = NULL;
   bool is_accessible;
   FindView(view, &profile, &is_accessible);
@@ skipping 127 matching lines @@
   std::string value = WideToUTF8(location_entry->GetText());
   std::wstring::size_type selection_start;
   std::wstring::size_type selection_end;
   location_entry->GetSelectionBounds(&selection_start, &selection_end);
 
   AccessibilityTextBoxInfo info(profile, name, false);
   info.SetValue(value, selection_start, selection_end);
   SendAccessibilityNotification(type, &info);
 #endif
 }