Cleanup: Use AUTH_SCHEME enum instead of a string.

Cleanup: Use AUTH_SCHEME enum instead of a string.

BUG=None
TEST=trybots


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71318

[cbentzel, 2011-01-07 19:33:03]

Asanka, for some reason codereview won't let me use your chromium.org account -
probably needs an update. 

This is a pretty straightforward change - the only things really worth scrutiny
are in http_auth.cc [GetSchemeName, and HandleChallengeResponse].

Eric had mentioned this as a cleanup after I introduced the AUTH_SCHEME enum.

[cbentzel, 2011-01-07 20:00:15]

I'm trying to figure out why the trybots are having problems building - the
patch they are including looks correct. Maybe I need to change the -r option.

[cbentzel, 2011-01-10 14:44:05]

The newest patch set adds AUTH_SCHEME_MOCK for unit tests.

I'm interested in your feedback about this - I'm not too happy with it myself.
Unfortunately, http_auth_handler.cc checks auth_scheme_ against AUTH_SCHEME_MAX,
so this enum can't simply be wrapped in #if defined(UNIT_TEST).

[eroman, 2011-01-10 19:32:39]

lgtm

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth.cc
File net/http/http_auth.cc (right):

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth.cc#newco...
net/http/http_auth.cc:179: return "invalid_scheme";
Can you add a NOTREACHED here?

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth.h
File net/http/http_auth.h (right):

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth.h#newcod...
net/http/http_auth.h:103: // TODO(cbentzel): Change these to return const char*
instead.
What function(s) is this comment referring to?

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth.h#newcod...
net/http/http_auth.h:118: static std::string GetSchemeName(Scheme scheme);
nit: I suggest calling this:
  const char* SchemeToString(Scheme scheme);

Which is consistent with some others like ErrorToString().

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth_cache.cc
File net/http/http_auth_cache.cc (right):

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth_cache.cc...
net/http/http_auth_cache.cc:146: HttpAuthCache::Entry::Entry()
Please update this to default-initialize scheme_ to something invalid.

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth_cache.h
File net/http/http_auth_cache.h (right):

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth_cache.h#...
net/http/http_auth_cache.h:122: // The authentication scheme string of the
challenge
"string" -- no longer applicable.

[cbentzel, 2011-01-11 16:54:18]

Thanks for the review, Eric.

I'll land, pending trybot results.

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth.cc
File net/http/http_auth.cc (right):

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth.cc#newco...
net/http/http_auth.cc:179: return "invalid_scheme";
On 2011/01/10 19:32:39, eroman wrote:
> Can you add a NOTREACHED here?

Done.

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth.h
File net/http/http_auth.h (right):

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth.h#newcod...
net/http/http_auth.h:103: // TODO(cbentzel): Change these to return const char*
instead.
On 2011/01/10 19:32:39, eroman wrote:
> What function(s) is this comment referring to?

For the GetChallengeHaeaderName/GetAuthorizationHeaderName/GetAuthTargetString +
GetSchemeName.

I removed for now and made GetSchemeName return const char* [and renamed to
SchemeToString as you suggested].

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth.h#newcod...
net/http/http_auth.h:118: static std::string GetSchemeName(Scheme scheme);
On 2011/01/10 19:32:39, eroman wrote:
> nit: I suggest calling this:
>   const char* SchemeToString(Scheme scheme);
> 
> Which is consistent with some others like ErrorToString().

Done.

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth_cache.h
File net/http/http_auth_cache.h (right):

http://codereview.chromium.org/6191001/diff/39001/net/http/http_auth_cache.h#...
net/http/http_auth_cache.h:122: // The authentication scheme string of the
challenge
On 2011/01/10 19:32:39, eroman wrote:
> "string" -- no longer applicable.

Done.