Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: net/http/http_auth_handler.h

Issue 6191001: Cleanup: Use AUTH_SCHEME enum instead of a string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Merge with trunk Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_controller.cc ('k') | net/http/http_auth_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler.h
===================================================================
--- net/http/http_auth_handler.h (revision 71164)
+++ net/http/http_auth_handler.h (working copy)
@@ -22,14 +22,6 @@
// HttpAuthHandler objects are typically created by an HttpAuthHandlerFactory.
class HttpAuthHandler {
public:
- enum AuthScheme {
- AUTH_SCHEME_BASIC = 0,
- AUTH_SCHEME_DIGEST,
- AUTH_SCHEME_NTLM,
- AUTH_SCHEME_NEGOTIATE,
- AUTH_SCHEME_MAX,
- };
-
HttpAuthHandler();
virtual ~HttpAuthHandler();
@@ -84,15 +76,10 @@
std::string* auth_token);
// The authentication scheme as an enumerated value.
- AuthScheme auth_scheme() const {
+ HttpAuth::Scheme auth_scheme() const {
return auth_scheme_;
}
- // Lowercase name of the auth scheme
- const std::string& scheme() const {
- return scheme_;
- }
-
// The realm value that was parsed during Init().
const std::string& realm() const {
return realm_;
@@ -171,11 +158,8 @@
std::string* auth_token) = 0;
// The auth-scheme as an enumerated value.
- AuthScheme auth_scheme_;
+ HttpAuth::Scheme auth_scheme_;
- // The lowercase auth-scheme {"basic", "digest", "ntlm", "negotiate"}
- std::string scheme_;
-
// The realm. Used by "basic" and "digest".
std::string realm_;
« no previous file with comments | « net/http/http_auth_controller.cc ('k') | net/http/http_auth_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698