Cleanup: Use AUTH_SCHEME enum instead of a string.

net/http/http_auth_cache.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_auth_cache.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 
 namespace {
@@ skipping 50 matching lines @@
 
 HttpAuthCache::HttpAuthCache() {
 }
 
 HttpAuthCache::~HttpAuthCache() {
 }
 
 // Performance: O(n), where n is the number of realm entries.
 HttpAuthCache::Entry* HttpAuthCache::Lookup(const GURL& origin,
                                             const std::string& realm,
-                                            const std::string& scheme) {
+                                            HttpAuth::Scheme scheme) {
   CheckOriginIsValid(origin);
 
   // Linear scan through the realm entries.
   for (EntryList::iterator it = entries_.begin(); it != entries_.end(); ++it) {
     if (it->origin() == origin && it->realm() == realm &&
         it->scheme() == scheme)
       return &(*it);
   }
   return NULL;  // No realm entry found.
 }
@@ skipping 15 matching lines @@
   // Linear scan through the realm entries.
   for (EntryList::iterator it = entries_.begin(); it != entries_.end(); ++it) {
     if (it->origin() == origin && it->HasEnclosingPath(parent_dir))
       return &(*it);
   }
   return NULL;  // No entry found.
 }
 
 HttpAuthCache::Entry* HttpAuthCache::Add(const GURL& origin,
                                          const std::string& realm,
-                                         const std::string& scheme,
+                                         HttpAuth::Scheme scheme,
                                          const std::string& auth_challenge,
                                          const string16& username,
                                          const string16& password,
                                          const std::string& path) {
   CheckOriginIsValid(origin);
   CheckPathIsValid(path);
 
   // Check for existing entry (we will re-use it if present).
   HttpAuthCache::Entry* entry = Lookup(origin, realm, scheme);
   if (!entry) {
@@ skipping 18 matching lines @@
   entry->password_ = password;
   entry->nonce_count_ = 1;
   entry->AddPath(path);
 
   return entry;
 }
 
 HttpAuthCache::Entry::~Entry() {
 }
 
 HttpAuthCache::Entry::Entry()

[eroman, 2011/01/10 19:32:39]

Please update this to default-initialize scheme_ to something invalid.

     : nonce_count_(0) {
 }
 
 void HttpAuthCache::Entry::AddPath(const std::string& path) {
   std::string parent_dir = GetParentDirectory(path);
   if (!HasEnclosingPath(parent_dir)) {
     // Remove any entries that have been subsumed by the new entry.
     paths_.remove_if(IsEnclosedBy(parent_dir));
 
     // Failsafe to prevent unbounded memory growth of the cache.
@@ skipping 19 matching lines @@
 }
 
 void HttpAuthCache::Entry::UpdateStaleChallenge(
     const std::string& auth_challenge) {
   auth_challenge_ = auth_challenge;
   nonce_count_ = 1;
 }
 
 bool HttpAuthCache::Remove(const GURL& origin,
                            const std::string& realm,
-                           const std::string& scheme,
+                           HttpAuth::Scheme scheme,
                            const string16& username,
                            const string16& password) {
   for (EntryList::iterator it = entries_.begin(); it != entries_.end(); ++it) {
     if (it->origin() == origin && it->realm() == realm &&
         it->scheme() == scheme) {
       if (username == it->username() && password == it->password()) {
         entries_.erase(it);
         return true;
       }
       return false;
     }
   }
   return false;
 }
 
 bool HttpAuthCache::UpdateStaleChallenge(const GURL& origin,
                                          const std::string& realm,
-                                         const std::string& scheme,
+                                         HttpAuth::Scheme scheme,
                                          const std::string& auth_challenge) {
   HttpAuthCache::Entry* entry = Lookup(origin, realm, scheme);
   if (!entry)
     return false;
   entry->UpdateStaleChallenge(auth_challenge);
   return true;
 }
 
 }  // namespace net