net/http/http_auth_handler_factory_unittest.cc - Issue 6191001: Cleanup: Use AUTH_SCHEME enum instead of a string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_factory_unittest.cc

Issue 6191001: Cleanup: Use AUTH_SCHEME enum instead of a string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Merge with trunk Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_auth_handler_factory_unittest.cc

===================================================================

--- net/http/http_auth_handler_factory_unittest.cc (revision 71164)

+++ net/http/http_auth_handler_factory_unittest.cc (working copy)

@@ -114,7 +114,7 @@

&handler);

EXPECT_EQ(OK, rv);

ASSERT_FALSE(handler.get() == NULL);

- EXPECT_STREQ("basic", handler->scheme().c_str());

+ EXPECT_EQ(HttpAuth::AUTH_SCHEME_BASIC, handler->auth_scheme());

EXPECT_STREQ("FooBar", handler->realm().c_str());

EXPECT_EQ(HttpAuth::AUTH_SERVER, handler->target());

EXPECT_FALSE(handler->encrypts_identity());

@@ -141,7 +141,7 @@

&handler);

EXPECT_EQ(OK, rv);

ASSERT_FALSE(handler.get() == NULL);

- EXPECT_STREQ("digest", handler->scheme().c_str());

+ EXPECT_EQ(HttpAuth::AUTH_SCHEME_DIGEST, handler->auth_scheme());

EXPECT_STREQ("FooBar", handler->realm().c_str());

EXPECT_EQ(HttpAuth::AUTH_PROXY, handler->target());

EXPECT_TRUE(handler->encrypts_identity());

@@ -157,7 +157,7 @@

&handler);

EXPECT_EQ(OK, rv);

ASSERT_FALSE(handler.get() == NULL);

- EXPECT_STREQ("ntlm", handler->scheme().c_str());

+ EXPECT_EQ(HttpAuth::AUTH_SCHEME_NTLM, handler->auth_scheme());

EXPECT_STREQ("", handler->realm().c_str());

EXPECT_EQ(HttpAuth::AUTH_SERVER, handler->target());

EXPECT_TRUE(handler->encrypts_identity());

@@ -173,7 +173,7 @@

&handler);

EXPECT_EQ(OK, rv);

ASSERT_FALSE(handler.get() == NULL);

- EXPECT_STREQ("negotiate", handler->scheme().c_str());

+ EXPECT_EQ(HttpAuth::AUTH_SCHEME_NEGOTIATE, handler->auth_scheme());

EXPECT_STREQ("", handler->realm().c_str());

EXPECT_EQ(HttpAuth::AUTH_SERVER, handler->target());

EXPECT_TRUE(handler->encrypts_identity());

« no previous file with comments | « net/http/http_auth_handler_digest.cc ('k') | net/http/http_auth_handler_mock.cc » ('j') | no next file with comments »