Issue 6178012: Bugfixes for the remoting setup wizard:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6178012: Bugfixes for the remoting setup wizard: (Closed)

Created:
9 years, 11 months ago by Sergey Ulanov

Modified:
9 years, 7 months ago

Reviewers:
hclam, Alpha Left Google

CC:
chromium-reviews, ncarter (slow), Sergey Ulanov, Raghu Simha, idana, dmac, awong, garykac, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Bugfixes for the remoting setup wizard: 1. Proper error message when directory rejects request - this requires changes in gaia_login.html to support custom error messages. 2. Fixed login OTP-enabled account. BUG=67218 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71277

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -26 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/remoting/remoting_resources_source.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/remoting/setup_flow_login_step.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/remoting/setup_flow_login_step.cc	View	5 chunks	+23 lines, -8 lines	0 comments	Download
M	chrome/browser/remoting/setup_flow_register_step.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/resources/gaia_login.html	View	5 chunks	+31 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alpha Left Google

9 years, 11 months ago (2011-01-12 21:15:01 UTC) #2

Funny I don't see args.error == 2 but this is very cool. LGTM.

Expand Messages | Collapse Messages