Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/installer/util/channel_info.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ceee/installer_dll/installer_helper.cc ('K') | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/util/create_reg_key_work_item.cc » ('j') | chrome/installer/util/delete_after_reboot_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/channel_info.cc
===================================================================
--- chrome/installer/util/channel_info.cc (revision 71561)
+++ chrome/installer/util/channel_info.cc (working copy)
@@ -116,11 +116,12 @@
namespace installer {
bool ChannelInfo::Initialize(const RegKey& key) {
- return key.ReadValue(google_update::kRegApField, &value_);
+ return (key.ReadValue(google_update::kRegApField, &value_) == ERROR_SUCCESS);
}
bool ChannelInfo::Write(RegKey* key) const {
- return key->WriteValue(google_update::kRegApField, value_.c_str());
+ return (key->WriteValue(google_update::kRegApField, value_.c_str())
+ == ERROR_SUCCESS);
grt (UTC plus 2) 2011/01/16 04:19:48 Wrapping and indentation.
amit 2011/01/16 07:54:28 Done.
}
bool ChannelInfo::GetChannelName(std::wstring* channel_name) const {
« ceee/installer_dll/installer_helper.cc ('K') | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/util/create_reg_key_work_item.cc » ('j') | chrome/installer/util/delete_after_reboot_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698