Regkey functions return error code instead of bool

chrome/installer/util/delete_after_reboot_helper.cc

Index: chrome/installer/util/delete_after_reboot_helper.cc
===================================================================
--- chrome/installer/util/delete_after_reboot_helper.cc	(revision 71561)
+++ chrome/installer/util/delete_after_reboot_helper.cc	(working copy)
@@ -379,13 +379,14 @@
 
   if (strings_to_keep.size() <= 1) {
     // We have only the trailing NULL string. Don't bother writing that.
-    return session_manager_key.DeleteValue(kPendingFileRenameOps);
+    return (session_manager_key.DeleteValue(kPendingFileRenameOps)
+        == ERROR_SUCCESS);

[grt (UTC plus 2), 2011/01/16 04:19:48]

Wrapping and indentation.

[amit, 2011/01/16 07:54:28]

Done.

   }
   std::vector<char> buffer;
   StringArrayToMultiSZBytes(strings_to_keep, &buffer);
   DCHECK(buffer.size() > 0);
   if (buffer.empty())
     return false;
-  return session_manager_key.WriteValue(kPendingFileRenameOps, &buffer[0],
-                                        buffer.size(), REG_MULTI_SZ);
+  return (session_manager_key.WriteValue(kPendingFileRenameOps, &buffer[0],
+      buffer.size(), REG_MULTI_SZ) == ERROR_SUCCESS);

[grt (UTC plus 2), 2011/01/16 04:19:48]

Should this be indented 4 spaces from the open paren above?

[amit, 2011/01/16 07:54:28]

If it fits in one line. It does not and it will make ERROR_SUCCESS dangle on the
next line 6 spaces from the left :)

 }