Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8180)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ceee/installer_dll/installer_helper.cc ('K') | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/util/channel_info.cc » ('j') | chrome/installer/util/channel_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/uninstall.cc
===================================================================
--- chrome/installer/setup/uninstall.cc (revision 71561)
+++ chrome/installer/setup/uninstall.cc (working copy)
@@ -181,7 +181,7 @@
ShellUtil::kRegShellOpen);
RegKey key(HKEY_LOCAL_MACHINE, reg_key.c_str(), KEY_READ);
std::wstring reg_exe;
- if (key.ReadValue(L"", &reg_exe) && reg_exe.length() > 2) {
+ if (key.ReadValue(L"", &reg_exe) == ERROR_SUCCESS && reg_exe.length() > 2) {
FilePath chrome_exe(product.package().path()
.Append(installer::kChromeExe));
// The path in the registry will always have quotes.
« ceee/installer_dll/installer_helper.cc ('K') | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/util/channel_info.cc » ('j') | chrome/installer/util/channel_info.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698