Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4263)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/installer/util/create_reg_key_work_item.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/installer/util/channel_info.cc ('K') | « chrome/installer/util/channel_info.cc ('k') | chrome/installer/util/create_reg_key_work_item_unittest.cc » ('j') | chrome/installer/util/delete_after_reboot_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/create_reg_key_work_item.cc
===================================================================
--- chrome/installer/util/create_reg_key_work_item.cc (revision 71561)
+++ chrome/installer/util/create_reg_key_work_item.cc (working copy)
@@ -55,7 +55,7 @@
key_path.assign(key_list_[i - 1]);
if (key.CreateWithDisposition(predefined_root_, key_path.c_str(),
- &disposition, KEY_READ)) {
+ &disposition, KEY_READ) == ERROR_SUCCESS) {
if (disposition == REG_OPENED_EXISTING_KEY) {
if (key_created_) {
// This should not happen. Someone created a subkey under the key
« chrome/installer/util/channel_info.cc ('K') | « chrome/installer/util/channel_info.cc ('k') | chrome/installer/util/create_reg_key_work_item_unittest.cc » ('j') | chrome/installer/util/delete_after_reboot_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698