Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 6068003: Fix handling of symbolic links in RemoveDirectory. Attempt at fixing repeated... (Closed)

Created:
9 years, 12 months ago by dmichael(do not use this one)
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, Nicolas Sylvain, pam+watch_chromium.org
Visibility:
Public.

Description

Fix handling of symbolic links in RemoveDirectory. Attempt at fixing repeated windows-sdk issue that has been causing the windows-sdk bot to fail with (nearly?) every commit. BUG= http://code.google.com/p/nativeclient/issues/detail?id=1285 TEST=Hacked script manually on the bot, tried it out. If somebody points me to a unit test infrastructure for these scripts, I'd be happy to add a test for this. Originally in CL: http://codereview.chromium.org/5975009/ Had to move once I had a writeable check-out. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M scripts/common/chromium_utils.py View 1 chunk +4 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698