Issue 5975009: Fix handling of symbolic links in RemoveDirectory. Attempt at fixing repeate...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5975009: Fix handling of symbolic links in RemoveDirectory. Attempt at fixing repeate... (Closed)

Created:
9 years, 12 months ago by dmichael(do not use this one)

Modified:
9 years, 7 months ago

Reviewers:
nsylvain, bradn

CC:
chromium-reviews, Nicolas Sylvain, pam+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/tools/buildbot/

Visibility:
Public.

Description

Fix handling of symbolic links in RemoveDirectory. Attempt at fixing repeated windows-sdk issue that has been causing the windows-sdk bot to fail with (nearly?) every commit. BUG= http://code.google.com/p/nativeclient/issues/detail?id=1285 TEST=Hacked script manually on the bot, tried it out. If somebody points me to a unit test infrastructure for these scripts, I'd be happy to add a test for this. Had to move to another CL when I went to a writeable check-out: http://codereview.chromium.org/6068003/

Patch Set 1 #

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	scripts/common/chromium_utils.py	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm, worth a try anyhow.

Expand Messages | Collapse Messages