scripts/common/chromium_utils.py - Issue 6068003: Fix handling of symbolic links in RemoveDirectory. Attempt at fixing repeated...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/common/chromium_utils.py

Issue 6068003: Fix handling of symbolic links in RemoveDirectory. Attempt at fixing repeated... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/buildbot/

Patch Set: Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/common/chromium_utils.py

===================================================================

--- scripts/common/chromium_utils.py (revision 70240)

+++ scripts/common/chromium_utils.py (working copy)

@@ -238,7 +238,10 @@

if win32_api_avail:

win32api.SetFileAttributes(path, win32con.FILE_ATTRIBUTE_NORMAL)

try:

- return rmfunc(path)

+ if os.path.islink(path):

+ return os.remove(path)

+ else:

+ return rmfunc(path)

except EnvironmentError, e:

if e.errno != errno.EACCES:

raise

« no previous file with comments | « no previous file | no next file » | no next file with comments »