Issue 6062003: Added ppapi::Context3D interface. The API has already been reviewed. I am add...

Issue 6062003: Added ppapi::Context3D interface. The API has already been reviewed. I am add... (Closed)

Created:
10 years ago by alokp

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org, brettw, piman

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Added ppapi::Context3D interface. The API has already been reviewed. I am adding the new API incrementally so as not to break the demos. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70037

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 6

Patch Set 4 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1445 lines, -1021 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1 2	4 chunks	+11 lines, -8 lines	0 comments	Download
M	gpu/demos/framework/pepper.cc	View	1 2	5 chunks	+12 lines, -11 lines	0 comments	Download
A	ppapi/c/dev/pp_graphics_3d_dev.h	View	1 2	1 chunk	+177 lines, -0 lines	0 comments	Download
A	ppapi/c/dev/ppb_context_3d_dev.h	View		1 chunk	+128 lines, -0 lines	0 comments	Download
M	ppapi/c/dev/ppb_graphics_3d_dev.h	View	1 2	1 chunk	+73 lines, -69 lines	0 comments	Download
M	ppapi/c/dev/ppb_opengles_dev.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
A	ppapi/cpp/dev/context_3d_dev.h	View		1 chunk	+38 lines, -0 lines	0 comments	Download
A	ppapi/cpp/dev/context_3d_dev.cc	View		1 chunk	+58 lines, -0 lines	0 comments	Download
M	ppapi/cpp/dev/graphics_3d_dev.h	View	1 2	1 chunk	+9 lines, -31 lines	0 comments	Download
M	ppapi/cpp/dev/graphics_3d_dev.cc	View	1 2	2 chunks	+21 lines, -73 lines	0 comments	Download
M	ppapi/cpp/instance.h	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	ppapi/cpp/instance.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/ppapi.gyp	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	ppapi/tests/all_c_includes.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View	1 2	3 chunks	+6 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	1 2	3 chunks	+5 lines, -5 lines	0 comments	Download
A	webkit/plugins/ppapi/ppb_context_3d_impl.h	View	1 2 3	1 chunk	+82 lines, -0 lines	0 comments	Download
A	webkit/plugins/ppapi/ppb_context_3d_impl.cc	View	1 2 3	1 chunk	+182 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_3d_impl.h	View	1 2	1 chunk	+1 line, -66 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_3d_impl.cc	View	1 2	1 chunk	+15 lines, -179 lines	0 comments	Download
A	webkit/plugins/ppapi/ppb_opengles_impl.h	View		1 chunk	+22 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_opengles_impl.cc	View	1 2	2 chunks	+586 lines, -572 lines	0 comments	Download
M	webkit/plugins/ppapi/resource.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

alokp

Please note that I will further split Surface3D from Context3D in the next CL.

10 years ago (2010-12-22 19:37:09 UTC) #1

brettw

http://codereview.chromium.org/6062003/diff/6002/webkit/plugins/ppapi/ppb_context_3d_impl.cc File webkit/plugins/ppapi/ppb_context_3d_impl.cc (right): http://codereview.chromium.org/6062003/diff/6002/webkit/plugins/ppapi/ppb_context_3d_impl.cc#newcode35 webkit/plugins/ppapi/ppb_context_3d_impl.cc:35: if (!context->Init(instance, config, share_context, attrib_list)) { Remove {} for ...

10 years ago (2010-12-22 22:56:21 UTC) #3

alokp

10 years ago (2010-12-22 23:04:48 UTC) #4

I see, LGTM

Expand Messages | Collapse Messages