Chromium Code Reviews
DescriptionUse shutil.rmtree's 'onerror' error handling parameter to catch and handle the error that occurs when it's used on a symlink. Ideally, we would just check os.path.islink as the code does for Linux/Mac, but os.path.islink doesn't work properly in python 2.x on Windows.
BUG= http://code.google.com/p/nativeclient/issues/detail?id=1285
TEST=Tested on manually on the bot as follows:
> mkdir test
> mkdir test\1
> mklink /D test\current test\1
> python -c "import chromium_utils; chromium_utils.RemoveDirectory('test')"
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70432
Patch Set 1 #Patch Set 2 : '' #Messages
Total messages: 3 (0 generated)
|