Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 6015012: Use shutil.rmtree's 'onerror' error handling parameter to catch and handle th... (Closed)

Created:
9 years, 11 months ago by dmichael(do not use this one)
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Use shutil.rmtree's 'onerror' error handling parameter to catch and handle the error that occurs when it's used on a symlink. Ideally, we would just check os.path.islink as the code does for Linux/Mac, but os.path.islink doesn't work properly in python 2.x on Windows. BUG= http://code.google.com/p/nativeclient/issues/detail?id=1285 TEST=Tested on manually on the bot as follows: > mkdir test > mkdir test\1 > mklink /D test\current test\1 > python -c "import chromium_utils; chromium_utils.RemoveDirectory('test')" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70432

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M scripts/common/chromium_utils.py View 1 2 chunks +34 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dmichael(do not use this one)
This supersedes the CL I did that attempted to use os.path.islink, which didn't work since ...
9 years, 11 months ago (2011-01-04 18:11:58 UTC) #1
nsylvain
LGTM
9 years, 11 months ago (2011-01-04 19:06:19 UTC) #2
bradn
9 years, 11 months ago (2011-01-04 19:06:28 UTC) #3
otherwise LGTM

Powered by Google App Engine
This is Rietveld 408576698