Issue 5995005: Fix a truckload of bugs as I'm trying it the commit-queue out on real changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5995005: Fix a truckload of bugs as I'm trying it the commit-queue out on real changes. (Closed)

Created:
10 years ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Nicolas Sylvain, Peter Mayo (wrong one)

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/commit-queue

Visibility:
Public.

Description

Fix a truckload of bugs as I'm trying it the commit-queue out on real changes. Allow subdirectory base urls because of a bug in git cl upload. The base url value is dependent of the current directory when git cl upload is called. Fix invalid regexp processing for white lists. Fix apply_patch() failing for git checkouts. Fix revision argument when calling verifiers and updating committer. Fix description management. Fix presubmit_support.Main() return code. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70094

Patch Set 1 #

Patch Set 2 : rebase against trunk #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -20 lines)			Patch
M	checkout.py	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	pending_manager.py	View	1	8 chunks	+12 lines, -9 lines	0 comments	Download
M	projects.py	View		3 chunks	+9 lines, -7 lines	0 comments	Download
M	verification/presubmit_check.py	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Dependent on http://codereview.chromium.org/6015008. It's getting close, it committed a patch already http://codereview.chromium.org/5958006/ but threw an ...

10 years ago (2010-12-22 22:21:20 UTC) #1

LGTM.

Expand Messages | Collapse Messages