Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: projects.py

Issue 5995005: Fix a truckload of bugs as I'm trying it the commit-queue out on real changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue
Patch Set: rebase against trunk Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pending_manager.py ('k') | verification/presubmit_check.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: projects.py
diff --git a/projects.py b/projects.py
index eeea08e8e6994a45417fbd9d4b4340efd45d1f62..07630c56341aa9b48944ceee92ffbdb00f7e6ec1 100755
--- a/projects.py
+++ b/projects.py
@@ -54,11 +54,11 @@ def _gen_chromium(root_dir, rietveld_obj, git_svn, no_try):
('foo',)))
verifiers.append(presubmit_check.PresubmitCheckVerifier())
- author_white_list = [r'^maruel@chromium\.org$']
- reviewers = [r'^\w+@(google\.com|chromium\.org)$']
+ author_white_list = [r'^maruel\@chromium\.org$']
+ reviewers = [r'^\w+\@(google\.com|chromium\.org)$']
project_bases = []
for base in SVN_BASES:
- project_bases.append('^%s/trunk/src$' % re.escape(base))
+ project_bases.append('^%s/trunk/src(|/.+)$' % re.escape(base))
project_bases.append(
'^%s$' % re.escape('http://git.chromium.org/git/chromium.git@trunk'))
return pending_manager.PendingManager(
@@ -83,7 +83,9 @@ def _gen_depot_tools(root_dir, rietveld_obj, git_svn, no_try):
def _gen_commit_queue(root_dir, rietveld_obj, git_svn, no_try):
- """Generates a PendingManager commit queue for chrome/trunk/tools/commit-queue."""
+ """Generates a PendingManager commit queue for
+ chrome/trunk/tools/commit-queue.
+ """
return _internal_simple('commit-queue', root_dir, rietveld_obj, git_svn,
no_try)
@@ -108,11 +110,11 @@ def _internal_simple(path, root_dir, rietveld_obj, git_svn, no_try):
'svn://svn.chromium.org/chrome/trunk/tools/' + path)
verifiers = [presubmit_check.PresubmitCheckVerifier()]
- author_white_list = [r'^\w+@chromium\.org$']
- reviewers = [r'^\w+@(google\.com|chromium\.org)$']
+ author_white_list = [r'^\w+\@chromium\.org$']
+ reviewers = [r'^\w+\@(google\.com|chromium\.org)$']
project_bases = []
for base in SVN_BASES:
- project_bases.append('^%s/trunk/tools/%s$' % (re.escape(base), path))
+ project_bases.append('^%s/trunk/tools/%s(|/.+)$' % (re.escape(base), path))
return pending_manager.PendingManager(
rietveld_obj,
local_checkout,
« no previous file with comments | « pending_manager.py ('k') | verification/presubmit_check.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698