Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: checkout.py

Issue 5995005: Fix a truckload of bugs as I'm trying it the commit-queue out on real changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue
Patch Set: rebase against trunk Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pending_manager.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: checkout.py
diff --git a/checkout.py b/checkout.py
index 4226cda9fb6f7c03b761428fa3450e8b2b89c802..e91ccefd85ff7314af13351c6eb11d4e2f646617 100644
--- a/checkout.py
+++ b/checkout.py
@@ -116,7 +116,7 @@ class SvnMixIn(object):
"""
self._check_call_svn(
['propset', '--revprop', 'svn:author',
- '-r', revision,
+ '-r', str(revision),
new_author,
self.svn_url])
@@ -250,6 +250,7 @@ class GitCheckoutBase(CheckoutBase):
'%s/%s' % (self.remote, self.remote_branch)])
self._check_call_git(['apply', '--index', '-p0'], stdin=patch_data)
self._check_call_git(['commit', '-m', 'Committed patch'])
+ return True
def commit(self, commit_message, user):
"""Updates the commit message.
« no previous file with comments | « no previous file | pending_manager.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698