Fix a truckload of bugs as I'm trying it the commit-queue out on real changes.

checkout.py

 # coding=utf8
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Manages a project checkout.
 
 Includes support for svn, git-svn and git.
 """
 
 import logging
@@ skipping 98 matching lines @@
 
   def _update_committer(self, revision, new_author):
     """Changes the author of a commit a posteriori.
 
     This is necessary since the actual commit is done with a "commit-bot"
     credential but the original patch author needs to be assigned authorship
     of the revision.
     """
     self._check_call_svn(
         ['propset', '--revprop', 'svn:author',
-        '-r', revision,
+        '-r', str(revision),
         new_author,
         self.svn_url])
 
 
 class SvnCheckout(CheckoutBase, SvnMixIn):
   """Manages a subversion checkout.
 
   Commit is not fully implemented yet. Reimplementing all the commands is
   slightly complex, svn add with history needs to be done with svn
   copy/rename/move and the situation quickly becomes harder when directories are
@@ skipping 113 matching lines @@
     if self.working_branch in branches:
       self._call_git(['branch', '-D', self.working_branch])
 
   def apply_patch(self, patch_data):
     """Applies a patch on 'working_branch'."""
     self._check_call_git(
         ['checkout', '-b', self.working_branch,
          '%s/%s' % (self.remote, self.remote_branch)])
     self._check_call_git(['apply', '--index', '-p0'], stdin=patch_data)
     self._check_call_git(['commit', '-m', 'Committed patch'])
+    return True
 
   def commit(self, commit_message, user):
     """Updates the commit message.
 
     Subclass needs to dcommit or push."""
     self._check_call_git(['commit', '--amend', '-m', commit_message])
 
   def _check_call_git(self, args, **kwargs):
     kwargs.setdefault('cwd', self.project_path)
     return subprocess2.check_call(['git'] + args, **kwargs)
@@ skipping 168 matching lines @@
         user, message))
     return 'FAKE'
 
   @property
   def project_name(self):
     return self.checkout.project_name
 
   @property
   def project_path(self):
     return self.checkout.project_path