Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: chrome/test/automation/automation_proxy_uitest.h

Issue 5967003: Refactor UITestBase/ProxyLauncher. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Nits fixed; homepage_ moved to UITestBase; process_, process_id_ moved to ProxyLauncher. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automation/automation_proxy_uitest.h
diff --git a/chrome/test/automation/automation_proxy_uitest.h b/chrome/test/automation/automation_proxy_uitest.h
index 0b5556fa5a50176bbbda9bc76e420547564001c3..a2df81a5bc7a074c278303a624c4a947eb429491 100644
--- a/chrome/test/automation/automation_proxy_uitest.h
+++ b/chrome/test/automation/automation_proxy_uitest.h
@@ -107,7 +107,8 @@ class ExternalTabUITestMockClient : public AutomationProxy {
// Base your external tab UI tests on this.
class ExternalTabUITest : public UITest {
public:
- ExternalTabUITest() : UITest(MessageLoop::TYPE_UI) {}
+ ExternalTabUITest() : UITest(MessageLoop::TYPE_UI) {
John Grabowski 2011/01/07 03:36:11 In a header, empty methods are usually {}, not {\n
dtu 2011/01/08 01:54:57 Done.
+ }
// Override UITest's CreateProxyLauncher to provide the unit test
// with our special implementation of AutomationProxy.
// This function is called from within UITest::SetUp().

Powered by Google App Engine
This is Rietveld 408576698