Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: chrome/test/automation/automation_proxy_uitest.cc

Issue 5967003: Refactor UITestBase/ProxyLauncher. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Nits fixed; homepage_ moved to UITestBase; process_, process_id_ moved to ProxyLauncher. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automation/automation_proxy_uitest.cc
diff --git a/chrome/test/automation/automation_proxy_uitest.cc b/chrome/test/automation/automation_proxy_uitest.cc
index 465b61023a1afc3f33462a0afa769b24cf2fc91f..7315af6cffd3dee5f2f7b27722333dea13946520 100644
--- a/chrome/test/automation/automation_proxy_uitest.cc
+++ b/chrome/test/automation/automation_proxy_uitest.cc
@@ -63,8 +63,19 @@ class ExternalTabUITestMockLauncher : public ProxyLauncher {
return *mock_;
}
- void InitializeConnection(UITestBase* ui_test_base) const {
- ui_test_base->LaunchBrowserAndServer();
+ void InitializeConnection(const CommandLine& arguments,
+ bool include_testing_id,
+ bool clear_profile,
+ FilePath& template_user_data,
+ ProfileType profile_type,
+ FilePath browser_directory,
+ bool show_window,
+ bool wait_for_initial_loads,
+ base::TimeTicks* browser_launch_time) {
+ LaunchBrowserAndServer(arguments, include_testing_id, clear_profile,
+ template_user_data, profile_type, browser_directory,
+ show_window, wait_for_initial_loads,
+ browser_launch_time);
}
std::string PrefixedChannelID() const {

Powered by Google App Engine
This is Rietveld 408576698