Chromium Code Reviews

Side by Side Diff: chrome/test/automation/automation_proxy_uitest.h

Issue 5967003: Refactor UITestBase/ProxyLauncher. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Nits fixed; homepage_ moved to UITestBase; process_, process_id_ moved to ProxyLauncher. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_UITEST_H_ 5 #ifndef CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_UITEST_H_
6 #define CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_UITEST_H_ 6 #define CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_UITEST_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 89 matching lines...)
100 gfx::NativeWindow host_window_; 100 gfx::NativeWindow host_window_;
101 101
102 // Simple dispatcher to above OnXXX methods. 102 // Simple dispatcher to above OnXXX methods.
103 virtual bool OnMessageReceived(const IPC::Message& msg); 103 virtual bool OnMessageReceived(const IPC::Message& msg);
104 virtual void InvalidateHandle(const IPC::Message& message); 104 virtual void InvalidateHandle(const IPC::Message& message);
105 }; 105 };
106 106
107 // Base your external tab UI tests on this. 107 // Base your external tab UI tests on this.
108 class ExternalTabUITest : public UITest { 108 class ExternalTabUITest : public UITest {
109 public: 109 public:
110 ExternalTabUITest() : UITest(MessageLoop::TYPE_UI) {} 110 ExternalTabUITest() : UITest(MessageLoop::TYPE_UI) {
John Grabowski 2011/01/07 03:36:11 In a header, empty methods are usually {}, not {\n
dtu 2011/01/08 01:54:57 Done.
111 }
111 // Override UITest's CreateProxyLauncher to provide the unit test 112 // Override UITest's CreateProxyLauncher to provide the unit test
112 // with our special implementation of AutomationProxy. 113 // with our special implementation of AutomationProxy.
113 // This function is called from within UITest::SetUp(). 114 // This function is called from within UITest::SetUp().
114 virtual ProxyLauncher* CreateProxyLauncher(); 115 virtual ProxyLauncher* CreateProxyLauncher();
115 protected: 116 protected:
116 // Filtered Inet will override automation callbacks for network resources. 117 // Filtered Inet will override automation callbacks for network resources.
117 virtual bool ShouldFilterInet() { 118 virtual bool ShouldFilterInet() {
118 return false; 119 return false;
119 } 120 }
120 ExternalTabUITestMockClient* mock_; 121 ExternalTabUITestMockClient* mock_;
121 std::string channel_id_; // Channel id of automation proxy. 122 std::string channel_id_; // Channel id of automation proxy.
122 }; 123 };
123 124
124 #endif // CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_UITEST_H_ 125 #endif // CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_UITEST_H_
OLDNEW

Powered by Google App Engine