chrome/browser/session_history_uitest.cc - Issue 5967003: Refactor UITestBase/ProxyLauncher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/session_history_uitest.cc

Issue 5967003: Refactor UITestBase/ProxyLauncher. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Nits fixed; homepage_ moved to UITestBase; process_, process_id_ moved to ProxyLauncher. Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/session_history_uitest.cc

diff --git a/chrome/browser/session_history_uitest.cc b/chrome/browser/session_history_uitest.cc

index 4889a814b5847ea932910128c42a53203c679864..9a49d429f21894d3cba4e53b531cb8ab3575bed5 100644

--- a/chrome/browser/session_history_uitest.cc

+++ b/chrome/browser/session_history_uitest.cc

@@ -156,7 +156,7 @@ TEST_F(SessionHistoryTest, MAYBE_FrameBackForward) {

ASSERT_TRUE(test_server_.Start());

// about:blank should be loaded first.

- GURL home(homepage_);

+ GURL home(chrome::kAboutBlankURL);

John Grabowski 2011/01/07 03:36:11 You added a set_homepage() to replace "homepage_ =

dtu 2011/01/08 01:54:57 Done.

ASSERT_FALSE(tab_->GoBack());

EXPECT_EQ(L"", GetTabTitle());

EXPECT_EQ(home, GetTabURL());