Issue 5938002: Remove legacy non-client-based geolocation code.

Issue 5938002: Remove legacy non-client-based geolocation code. (Closed)

Created:
10 years ago by John Knottenbelt

Modified:
9 years, 7 months ago

Reviewers:
bulach

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove legacy non-client-based geolocation code. BUG=59907 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70602

Patch Set 2 : Remove non-client-based geolocation code. #

Total comments: 4

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -517 lines)			Patch
M	chrome/browser/geolocation/geolocation_dispatcher_host.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_permission_context.cc	View		1 chunk	+0 lines, -15 lines	2 comments	Download
M	chrome/browser/geolocation/geolocation_permission_context_unittest.cc	View	1	1 chunk	+0 lines, -30 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+0 lines, -8 lines	2 comments	Download
M	chrome/chrome_renderer.gypi	View	1	2 chunks	+0 lines, -10 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/renderer/geolocation_dispatcher.h	View	1	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/renderer/geolocation_dispatcher.cc	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
D	chrome/renderer/geolocation_dispatcher_old.h	View	1	1 chunk	+0 lines, -68 lines	0 comments	Download
D	chrome/renderer/geolocation_dispatcher_old.cc	View		1 chunk	+0 lines, -116 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1	2 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1	2 chunks	+0 lines, -21 lines	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.cc	View	1	4 chunks	+0 lines, -22 lines	0 comments	Download
D	webkit/tools/test_shell/test_geolocation_service.h	View		1 chunk	+0 lines, -67 lines	0 comments	Download
D	webkit/tools/test_shell/test_geolocation_service.cc	View		1 chunk	+0 lines, -67 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	1	4 chunks	+0 lines, -8 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1	4 chunks	+0 lines, -17 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1	5 chunks	+1 line, -35 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Knottenbelt

This removes Chromium-side non-client-based geolocation code.

9 years, 11 months ago (2011-01-05 09:48:14 UTC) #1

bulach

LGTM yay, fantastic, thanks! just one suggestion for a follow up cleanup: http://codereview.chromium.org/5938002/diff/2001/chrome/browser/geolocation/geolocation_permission_context.cc File chrome/browser/geolocation/geolocation_permission_context.cc ...

9 years, 11 months ago (2011-01-05 10:12:28 UTC) #2

John Knottenbelt

9 years, 11 months ago (2011-01-05 12:01:31 UTC) #3

http://codereview.chromium.org/5938002/diff/2001/chrome/browser/geolocation/g...
File chrome/browser/geolocation/geolocation_permission_context.cc (right):

http://codereview.chromium.org/5938002/diff/2001/chrome/browser/geolocation/g...
chrome/browser/geolocation/geolocation_permission_context.cc:449: int
render_process_id, int render_view_id, int bridge_id) {
Agree.
On 2011/01/05 10:12:29, bulach wrote:
> in a follow up CL, you may want to entirely remove both Start/StopUpdating,
> it'll make the permissioncontext much nicer!!

http://codereview.chromium.org/5938002/diff/2001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (left):

http://codereview.chromium.org/5938002/diff/2001/chrome/chrome_browser.gypi#o...
chrome/chrome_browser.gypi:4383: 'defines': [
'ENABLE_CLIENT_BASED_GEOLOCATION=1' ]
Will do, however, I don't think it will require a clobber. The flag will still
be defined when building WebKit (feature_overrides.gypi), but it will no longer
be defined in the Chrome sources as no source code there will depend on it. 

On 2011/01/05 10:12:29, bulach wrote:
> remember to coordinate with the sheriffs for a possible clobber..

Expand Messages | Collapse Messages