Remove legacy non-client-based geolocation code.

chrome/browser/geolocation/geolocation_permission_context.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/geolocation/geolocation_permission_context.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_thread.h"
@@ skipping 421 matching lines @@
   CancelPendingInfoBarRequest(render_process_id, render_view_id, bridge_id);
 }
 
 void GeolocationPermissionContext::StartUpdatingRequested(
     int render_process_id, int render_view_id, int bridge_id,
     const GURL& requesting_frame) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   // Note we cannot store the arbitrator as a member as it is not thread safe.
   GeolocationProvider* provider = GeolocationProvider::GetInstance();
 
-#if defined(ENABLE_CLIENT_BASED_GEOLOCATION)
   // Client-based Geolocation uses a preemptive permission model, so permission
   // ought to have been requested and granted before the controller requests
   // the client to start updating.
   DCHECK(provider->HasPermissionBeenGranted());
-#else
-  // WebKit will not request permission until it has received a valid
-  // location, but the google network location provider will not give a
-  // valid location until the user has granted permission. So we cut the Gordian
-  // Knot by reusing the the 'start updating' request to also trigger
-  // a 'permission request' should the provider still be awaiting permission.
-  if (!provider->HasPermissionBeenGranted()) {
-    RequestGeolocationPermission(render_process_id, render_view_id, bridge_id,
-                                 requesting_frame);
-  }
-#endif
 }
 
 void GeolocationPermissionContext::StopUpdatingRequested(
     int render_process_id, int render_view_id, int bridge_id) {

[bulach, 2011/01/05 10:12:29]

in a follow up CL, you may want to entirely remove both Start/StopUpdating,
it'll make the permissioncontext much nicer!!

[John Knottenbelt, 2011/01/05 12:01:31]

Agree.
On 2011/01/05 10:12:29, bulach wrote:

-#if !defined(ENABLE_CLIENT_BASED_GEOLOCATION)
-  CancelPendingInfoBarRequest(render_process_id, render_view_id, bridge_id);
-#endif
 }
 
 void GeolocationPermissionContext::NotifyPermissionSet(
     int render_process_id, int render_view_id, int bridge_id,
     const GURL& requesting_frame, bool allowed) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   TabContents* tab_contents =
       tab_util::GetTabContentsByID(render_process_id, render_view_id);
 
@@ skipping 32 matching lines @@
         BrowserThread::UI, FROM_HERE,
         NewRunnableMethod(this,
             &GeolocationPermissionContext::CancelPendingInfoBarRequest,
             render_process_id, render_view_id, bridge_id));
      return;
   }
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   geolocation_infobar_queue_controller_->CancelInfoBarRequest(
       render_process_id, render_view_id, bridge_id);
 }