Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: webkit/tools/test_shell/layout_test_controller.cc

Issue 5938002: Remove legacy non-client-based geolocation code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove non-client-based geolocation code. Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/tools/test_shell/layout_test_controller.cc
diff --git a/webkit/tools/test_shell/layout_test_controller.cc b/webkit/tools/test_shell/layout_test_controller.cc
index 9b0a93877c36c100a264b2c180b60e3ae956757b..62e42120ec35d48c2dec7779281a7aec5f78b18a 100644
--- a/webkit/tools/test_shell/layout_test_controller.cc
+++ b/webkit/tools/test_shell/layout_test_controller.cc
@@ -26,11 +26,7 @@
#include "third_party/WebKit/WebKit/chromium/public/WebDocument.h"
#include "third_party/WebKit/WebKit/chromium/public/WebElement.h"
#include "third_party/WebKit/WebKit/chromium/public/WebFrame.h"
-#if defined(ENABLE_CLIENT_BASED_GEOLOCATION)
#include "third_party/WebKit/WebKit/chromium/public/WebGeolocationClientMock.h"
-#else
-#include "third_party/WebKit/WebKit/chromium/public/WebGeolocationServiceMock.h"
-#endif
#include "third_party/WebKit/WebKit/chromium/public/WebKit.h"
#include "third_party/WebKit/WebKit/chromium/public/WebScriptSource.h"
#include "third_party/WebKit/WebKit/chromium/public/WebSecurityPolicy.h"
@@ -62,10 +58,6 @@ using WebKit::WebSize;
using WebKit::WebString;
using WebKit::WebURL;
-#if !defined(ENABLE_CLIENT_BASED_GEOLOCATION)
-using WebKit::WebGeolocationServiceMock;
-#endif
-
TestShell* LayoutTestController::shell_ = NULL;
// Most of these flags need to be cleared in Reset() so that they get turned
// off between each test run.
@@ -1500,12 +1492,8 @@ void LayoutTestController::setGeolocationPermission(const CppArgumentList& args,
CppVariant* result) {
if (args.size() < 1 || !args[0].isBool())
return;
-#if defined(ENABLE_CLIENT_BASED_GEOLOCATION)
shell_->geolocation_client_mock()->setPermission(
args[0].ToBoolean());
-#else
- shell_->delegate()->SetGeolocationPermission(args[0].ToBoolean());
-#endif
}
void LayoutTestController::setMockGeolocationPosition(
@@ -1513,26 +1501,16 @@ void LayoutTestController::setMockGeolocationPosition(
if (args.size() < 3 ||
!args[0].isNumber() || !args[1].isNumber() || !args[2].isNumber())
return;
-#if defined(ENABLE_CLIENT_BASED_GEOLOCATION)
shell_->geolocation_client_mock()->setPosition(
args[0].ToDouble(), args[1].ToDouble(), args[2].ToDouble());
-#else
- WebGeolocationServiceMock::setMockGeolocationPosition(
- args[0].ToDouble(), args[1].ToDouble(), args[2].ToDouble());
-#endif
}
void LayoutTestController::setMockGeolocationError(const CppArgumentList& args,
CppVariant* result) {
if (args.size() < 2 || !args[0].isNumber() || !args[1].isString())
return;
-#if defined(ENABLE_CLIENT_BASED_GEOLOCATION)
shell_->geolocation_client_mock()->setError(
args[0].ToInt32(), WebString::fromUTF8(args[1].ToString()));
-#else
- WebGeolocationServiceMock::setMockGeolocationError(
- args[0].ToInt32(), WebString::fromUTF8(args[1].ToString()));
-#endif
}
void LayoutTestController::markerTextForListItem(const CppArgumentList& args,

Powered by Google App Engine
This is Rietveld 408576698