Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Side by Side Diff: chrome/renderer/render_view.h

Issue 5938002: Remove legacy non-client-based geolocation code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove non-client-based geolocation code. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_RENDER_VIEW_H_ 5 #ifndef CHROME_RENDERER_RENDER_VIEW_H_
6 #define CHROME_RENDERER_RENDER_VIEW_H_ 6 #define CHROME_RENDERER_RENDER_VIEW_H_
7 #pragma once 7 #pragma once
8 8
9 #include <deque> 9 #include <deque>
10 #include <map> 10 #include <map>
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 const WebKit::WebString& label, 490 const WebKit::WebString& label,
491 int unique_id, 491 int unique_id,
492 unsigned index); 492 unsigned index);
493 virtual void didSelectAutoFillSuggestion(const WebKit::WebNode& node, 493 virtual void didSelectAutoFillSuggestion(const WebKit::WebNode& node,
494 const WebKit::WebString& value, 494 const WebKit::WebString& value,
495 const WebKit::WebString& label, 495 const WebKit::WebString& label,
496 int unique_id); 496 int unique_id);
497 virtual void didClearAutoFillSelection(const WebKit::WebNode& node); 497 virtual void didClearAutoFillSelection(const WebKit::WebNode& node);
498 virtual void didAcceptAutocompleteSuggestion( 498 virtual void didAcceptAutocompleteSuggestion(
499 const WebKit::WebInputElement& element); 499 const WebKit::WebInputElement& element);
500 // TODO(jknotten): Remove once building with ENABLE_CLIENT_BASED_GEOLOCATION.
501 virtual WebKit::WebGeolocationClient* geolocationClient(); 500 virtual WebKit::WebGeolocationClient* geolocationClient();
502 virtual WebKit::WebGeolocationService* geolocationService();
503 virtual WebKit::WebSpeechInputController* speechInputController( 501 virtual WebKit::WebSpeechInputController* speechInputController(
504 WebKit::WebSpeechInputListener* listener); 502 WebKit::WebSpeechInputListener* listener);
505 virtual WebKit::WebDeviceOrientationClient* deviceOrientationClient(); 503 virtual WebKit::WebDeviceOrientationClient* deviceOrientationClient();
506 virtual void zoomLimitsChanged(double minimum_level, double maximum_level); 504 virtual void zoomLimitsChanged(double minimum_level, double maximum_level);
507 virtual void zoomLevelChanged(); 505 virtual void zoomLevelChanged();
508 506
509 // WebKit::WebFrameClient implementation ------------------------------------- 507 // WebKit::WebFrameClient implementation -------------------------------------
510 508
511 virtual WebKit::WebPlugin* createPlugin( 509 virtual WebKit::WebPlugin* createPlugin(
512 WebKit::WebFrame* frame, 510 WebKit::WebFrame* frame,
(...skipping 873 matching lines...) Expand 10 before | Expand all | Expand 10 after
1386 1384
1387 // Holds a reference to the service which provides desktop notifications. 1385 // Holds a reference to the service which provides desktop notifications.
1388 scoped_ptr<NotificationProvider> notification_provider_; 1386 scoped_ptr<NotificationProvider> notification_provider_;
1389 1387
1390 // PrintWebViewHelper handles printing. Note that this object is constructed 1388 // PrintWebViewHelper handles printing. Note that this object is constructed
1391 // when printing for the first time but only destroyed with the RenderView. 1389 // when printing for the first time but only destroyed with the RenderView.
1392 scoped_ptr<PrintWebViewHelper> print_helper_; 1390 scoped_ptr<PrintWebViewHelper> print_helper_;
1393 1391
1394 scoped_refptr<AudioMessageFilter> audio_message_filter_; 1392 scoped_refptr<AudioMessageFilter> audio_message_filter_;
1395 1393
1396 #if defined(ENABLE_CLIENT_BASED_GEOLOCATION) 1394 // The geolocation dispatcher attached to this view, lazily initialized.
1397 // the geolocation dispatcher attached to this view, lazily initialized.
1398 scoped_ptr<GeolocationDispatcher> geolocation_dispatcher_; 1395 scoped_ptr<GeolocationDispatcher> geolocation_dispatcher_;
1399 #else
1400 // TODO(jknotten): Remove once building with ENABLE_CLIENT_BASED_GEOLOCATION.
1401 scoped_ptr<GeolocationDispatcherOld> geolocation_dispatcher_;
1402 #endif
1403 1396
1404 // Handles accessibility requests into the renderer side, as well as 1397 // Handles accessibility requests into the renderer side, as well as
1405 // maintains the cache and other features of the accessibility tree. 1398 // maintains the cache and other features of the accessibility tree.
1406 scoped_ptr<WebKit::WebAccessibilityCache> accessibility_; 1399 scoped_ptr<WebKit::WebAccessibilityCache> accessibility_;
1407 1400
1408 // Collect renderer accessibility notifications until they are ready to be 1401 // Collect renderer accessibility notifications until they are ready to be
1409 // sent to the browser. 1402 // sent to the browser.
1410 std::vector<RendererAccessibilityNotification> 1403 std::vector<RendererAccessibilityNotification>
1411 pending_accessibility_notifications_; 1404 pending_accessibility_notifications_;
1412 1405
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
1508 // ADDING NEW DATA? Please see if it fits appropriately in one of the above 1501 // ADDING NEW DATA? Please see if it fits appropriately in one of the above
1509 // sections rather than throwing it randomly at the end. If you're adding a 1502 // sections rather than throwing it randomly at the end. If you're adding a
1510 // bunch of stuff, you should probably create a helper class and put your 1503 // bunch of stuff, you should probably create a helper class and put your
1511 // data and methods on that to avoid bloating RenderView more. 1504 // data and methods on that to avoid bloating RenderView more.
1512 // --------------------------------------------------------------------------- 1505 // ---------------------------------------------------------------------------
1513 1506
1514 DISALLOW_COPY_AND_ASSIGN(RenderView); 1507 DISALLOW_COPY_AND_ASSIGN(RenderView);
1515 }; 1508 };
1516 1509
1517 #endif // CHROME_RENDERER_RENDER_VIEW_H_ 1510 #endif // CHROME_RENDERER_RENDER_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698