Issue 5905006: Revert 69490 - base/version: remove wstring version...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5905006: Revert 69490 - base/version: remove wstring version... (Closed)

Created:
10 years ago by sanjeevr

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, pam+watch_chromium.org, amit, jam, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org, Erik does not do reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 69490 - base/version: remove wstring version And fix callers. BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/5848005 TBR=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69491

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -37 lines)			Patch
M	base/version.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	base/version.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/app/client_util.cc	View	3 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/enumerate_modules_model_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/external_registry_extension_provider_win.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/gpu_blacklist.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/about_chrome_view.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/about_chrome_view.cc	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome_frame/dll_redirector.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	webkit/glue/plugins/plugin_group.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages