Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: chrome/browser/ui/views/about_chrome_view.cc

Issue 5905006: Revert 69490 - base/version: remove wstring version... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/about_chrome_view.h ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/about_chrome_view.cc
===================================================================
--- chrome/browser/ui/views/about_chrome_view.cc (revision 69490)
+++ chrome/browser/ui/views/about_chrome_view.cc (working copy)
@@ -156,16 +156,16 @@
return;
}
- current_version_ = version_info.Version();
+ current_version_ = ASCIIToWide(version_info.Version());
std::string version_modifier = platform_util::GetVersionStringModifier();
if (!version_modifier.empty())
- version_details_ += " " + version_modifier;
+ version_details_ += L" " + ASCIIToWide(version_modifier);
#if !defined(GOOGLE_CHROME_BUILD)
- version_details_ += " (";
- version_details_ += version_info.LastChange();
- version_details_ += ")";
+ version_details_ += L" (";
+ version_details_ += ASCIIToWide(version_info.LastChange());
+ version_details_ += L")";
#endif
// Views we will add to the *parent* of this dialog, since it will display
@@ -210,7 +210,7 @@
// This is a text field so people can copy the version number from the dialog.
version_label_ = new views::Textfield();
- version_label_->SetText(ASCIIToUTF16(current_version_ + version_details_));
+ version_label_->SetText(WideToUTF16Hack(current_version_ + version_details_));
version_label_->SetReadOnly(true);
version_label_->RemoveBorder();
version_label_->SetTextColor(SK_ColorBLACK);
@@ -763,7 +763,7 @@
std::wstring update_label_text =
l10n_util::GetStringF(IDS_UPGRADE_ALREADY_UP_TO_DATE,
l10n_util::GetString(IDS_PRODUCT_NAME),
- ASCIIToUTF16(current_version_));
+ current_version_);
#endif
if (base::i18n::IsRTL()) {
update_label_text.push_back(
« no previous file with comments | « chrome/browser/ui/views/about_chrome_view.h ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698