base/version: remove wstring version

base/version: remove wstring version

And fix callers.

BUG=23581
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70098

[Evan Martin, 2010-12-16 21:36:55]

I am back!

[viettrungluu, 2010-12-16 23:49:13]

LGTM on everything else, I think, at least assuming version strings are all
respectable ASCII. I hope I didn't miss anything, since who knows what kind of
weird (e.g., update-related) breakage that might cause.

http://codereview.chromium.org/5848005/diff/1/chrome/app/client_util.cc
File chrome/app/client_util.cc (left):

http://codereview.chromium.org/5848005/diff/1/chrome/app/client_util.cc#oldco...
chrome/app/client_util.cc:244: version_env_string.clear();
It seems to me that you should keep the equivalent of this line. |GetVersion()|
may not modify the version string output in case of failure.

[Evan Martin, 2010-12-21 05:21:16]

Sorry, I had to make a bunch more changes.  Please take another look.

[viettrungluu, 2010-12-21 05:43:04]

On 2010/12/21 05:21:16, Evan Martin wrote:
> Sorry, I had to make a bunch more changes.  Please take another look.

I think you still need to upload a new patch set?

[Evan Martin, 2010-12-21 17:18:50]

me: type type type type <enter>
ok, i pinged on the cl, time to go home!

computer: "please press enter to continue"

FFFFUUUU

new version up

[Evan Martin, 2010-12-22 23:48:54]

timing out trung, trying avi since he's been sending me similar changes

[Avi (use Gerrit), 2010-12-22 23:50:58]

LGTM