Chromium Code Reviews

Unified Diff: chrome/browser/extensions/external_registry_extension_provider_win.cc

Issue 5905006: Revert 69490 - base/version: remove wstring version... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « chrome/browser/enumerate_modules_model_win.cc ('k') | chrome/browser/gpu_blacklist.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/external_registry_extension_provider_win.cc
===================================================================
--- chrome/browser/extensions/external_registry_extension_provider_win.cc (revision 69490)
+++ chrome/browser/extensions/external_registry_extension_provider_win.cc (working copy)
@@ -58,8 +58,7 @@
StringToLowerASCII(&id);
scoped_ptr<Version> version;
- version.reset(Version::GetVersionFromString(
- WideToASCII(extension_version)));
+ version.reset(Version::GetVersionFromString(extension_version));
if (!version.get()) {
LOG(ERROR) << "Invalid version value " << extension_version
<< " for key " << key_path;
@@ -104,10 +103,8 @@
if (!key.ReadValue(kRegistryExtensionVersion, &extension_version))
return false;
- if (version) {
- version->reset(Version::GetVersionFromString(
- WideToASCII(extension_version)));
- }
+ if (version)
+ version->reset(Version::GetVersionFromString(extension_version));
if (location)
*location = Extension::EXTERNAL_REGISTRY;
« no previous file with comments | « chrome/browser/enumerate_modules_model_win.cc ('k') | chrome/browser/gpu_blacklist.cc » ('j') | no next file with comments »

Powered by Google App Engine