Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5701004: Rename ResourceMessageFilter to RenderMessageFilter, since that's what it act... (Closed)

Created:
10 years ago by jam
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Rename ResourceMessageFilter to RenderMessageFilter, since that's what it actually is. I will add a ResourceMessageFilter just for resource IPCs in a future change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69076

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -2623 lines) Patch
M chrome/browser/appcache/appcache_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_resource_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/file_system/file_system_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_dispatcher_host_old.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gpu_process_host.h View 4 chunks +9 lines, -12 lines 0 comments Download
M chrome/browser/gpu_process_host.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/plugin_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ppapi_plugin_process_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ppapi_plugin_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/renderer_host/render_message_filter.h View 8 chunks +20 lines, -20 lines 0 comments Download
A + chrome/browser/renderer_host/render_message_filter.cc View 1 76 chunks +164 lines, -165 lines 0 comments Download
D chrome/browser/renderer_host/resource_message_filter.h View 1 chunk +0 lines, -539 lines 0 comments Download
D chrome/browser/renderer_host/resource_message_filter.cc View 1 chunk +0 lines, -1763 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter_gtk.cc View 11 chunks +60 lines, -61 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter_win.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/speech/speech_input_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/worker_host/message_port_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/worker_host/worker_process_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/worker_host/worker_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/media/audio_renderer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
10 years ago (2010-12-13 23:04:30 UTC) #1
willchan no longer on Chromium
LGTM mod the need to re-sort in a few places. http://codereview.chromium.org/5701004/diff/1/chrome/browser/geolocation/geolocation_dispatcher_host_old.cc File chrome/browser/geolocation/geolocation_dispatcher_host_old.cc (right): http://codereview.chromium.org/5701004/diff/1/chrome/browser/geolocation/geolocation_dispatcher_host_old.cc#newcode17 ...
10 years ago (2010-12-13 23:09:07 UTC) #2
jam
all done, thanks On Mon, Dec 13, 2010 at 3:09 PM, <willchan@chromium.org> wrote: > LGTM ...
10 years ago (2010-12-14 00:01:30 UTC) #3
Timur Iskhodzhanov
Please watch the memory waterfall after commiting next time - the new name didn't match ...
10 years ago (2010-12-14 06:55:39 UTC) #4
jam
10 years ago (2010-12-14 17:25:40 UTC) #5 
sorry about that, I only looked at the main waterfall and console.

can we get the memory bots to email on redness like other bots?

On Mon, Dec 13, 2010 at 10:55 PM, <timurrrr@chromium.org> wrote:

> Please watch the memory waterfall after commiting next time - the new name
> didn't match older suppressions and all the Valgrind bots gone red in an
> instant
> and they are red for 6+ hours already.
>
>
> On 2010/12/14 00:01:30, John Abd-El-Malek wrote:
>
>> all done, thanks
>>
>
>  On Mon, Dec 13, 2010 at 3:09 PM, <mailto:willchan@chromium.org> wrote:
>>
>
>  > LGTM mod the need to re-sort in a few places.
>> >
>> >
>> >
>> >
>>
>
>
>
http://codereview.chromium.org/5701004/diff/1/chrome/browser/geolocation/geol...
>
>> > File chrome/browser/geolocation/geolocation_dispatcher_host_old.cc
>> > (right):
>> >
>> >
>> >
>>
>
>
>
http://codereview.chromium.org/5701004/diff/1/chrome/browser/geolocation/geol...
>
>> > chrome/browser/geolocation/geolocation_dispatcher_host_old.cc:17:
>> > #include "chrome/browser/renderer_host/render_message_filter.h"
>> > sort alphabetically
>> >
>> >
>> >
>>
>
>
>
http://codereview.chromium.org/5701004/diff/1/chrome/browser/in_process_webki...
>
>> > File chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc
>> > (right):
>> >
>> >
>> >
>>
>
>
>
http://codereview.chromium.org/5701004/diff/1/chrome/browser/in_process_webki...
>
>> > chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc:15:
>> > #include "chrome/browser/renderer_host/render_message_filter.h"
>> > sort
>> >
>> >
>> >
>>
>
>
>
http://codereview.chromium.org/5701004/diff/1/chrome/browser/renderer_host/br...
>
>> > File chrome/browser/renderer_host/browser_render_process_host.cc
>> > (right):
>> >
>> >
>> >
>>
>
>
>
http://codereview.chromium.org/5701004/diff/1/chrome/browser/renderer_host/br...
>
>> > chrome/browser/renderer_host/browser_render_process_host.cc:58: #include
>> >
>> > "chrome/browser/renderer_host/render_message_filter.h"
>> > sort
>> >
>> >
>> >
>>
>
>
>
http://codereview.chromium.org/5701004/diff/1/chrome/browser/renderer_host/sa...
>
>> > File chrome/browser/renderer_host/safe_browsing_resource_handler.cc
>> > (right):
>> >
>> >
>> >
>>
>
>
>
http://codereview.chromium.org/5701004/diff/1/chrome/browser/renderer_host/sa...
>
>> > chrome/browser/renderer_host/safe_browsing_resource_handler.cc:10:
>> > #include "chrome/browser/renderer_host/render_message_filter.h"
>> > sort
>> >
>> >
>> http://codereview.chromium.org/5701004/diff/1/chrome/chrome_browser.gypi
>> > File chrome/chrome_browser.gypi (right):
>> >
>> >
>> >
>>
>
>
>
http://codereview.chromium.org/5701004/diff/1/chrome/chrome_browser.gypi#newc...
>
>> > chrome/chrome_browser.gypi:2177:
>> > 'browser/renderer_host/render_message_filter.cc',
>> > sort
>> >
>> >
>> > http://codereview.chromium.org/5701004/
>> >
>>
>
>
>
> http://codereview.chromium.org/5701004/
>

Powered by Google App Engine
This is Rietveld 408576698