Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 5676003: Make shader and program object lifetimes match OpenGL ES spec.... (Closed)

Created:
10 years ago by greggman
Modified:
9 years, 7 months ago
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Make shader and program object lifetimes match OpenGL ES spec. TEST=unit tests BUG=65705 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69039

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -97 lines) Patch
M gpu/command_buffer/client/gles2_implementation.cc View 2 chunks +29 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 14 chunks +26 lines, -27 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 1 2 6 chunks +34 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 2 3 4 chunks +59 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 1 2 3 5 chunks +126 lines, -16 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.h View 1 2 5 chunks +31 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.cc View 1 2 2 chunks +31 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/shader_manager_unittest.cc View 3 chunks +70 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
greggman
Please review when you get a chance.
10 years ago (2010-12-10 22:04:03 UTC) #1
apatrick
10 years ago (2010-12-13 19:13:09 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698