Make shader and program object lifetimes match OpenGL ES spec....

gpu/command_buffer/service/shader_manager_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/shader_manager.h"
 
 #include "base/scoped_ptr.h"
 #include "gpu/command_buffer/common/gl_mock.h"
 #include "gpu/command_buffer/service/mocks.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 26 matching lines @@
 
   // Use StrictMock to make 100% sure we know how GL will be called.
   scoped_ptr< ::testing::StrictMock< ::gfx::MockGLInterface> > gl_;
   ShaderManager manager_;
 };
 
 TEST_F(ShaderManagerTest, Basic) {
   const GLuint kClient1Id = 1;
   const GLuint kService1Id = 11;
   const GLenum kShader1Type = GL_VERTEX_SHADER;
-  const std::string kClient1Source("hello world");
   const GLuint kClient2Id = 2;
   // Check we can create shader.
   manager_.CreateShaderInfo(kClient1Id, kService1Id, kShader1Type);
   // Check shader got created.
   ShaderManager::ShaderInfo* info1 = manager_.GetShaderInfo(kClient1Id);
   ASSERT_TRUE(info1 != NULL);
-  EXPECT_EQ(kService1Id, info1->service_id());
-  // Check if the shader has correct type.
-  EXPECT_EQ(kShader1Type, info1->shader_type());
-  EXPECT_FALSE(info1->IsValid());
-  EXPECT_STREQ("", info1->log_info().c_str());
-  const char* kLog = "foo";
-  info1->SetStatus(true, kLog, NULL);
-  EXPECT_TRUE(info1->IsValid());
-  EXPECT_STREQ(kLog, info1->log_info().c_str());
-  // Check we can set its source.
-  info1->Update(kClient1Source);
-  EXPECT_STREQ(kClient1Source.c_str(), info1->source().c_str());
   // Check we get nothing for a non-existent shader.
   EXPECT_TRUE(manager_.GetShaderInfo(kClient2Id) == NULL);
-  // Check trying to a remove non-existent shaders does not crash.
-  manager_.RemoveShaderInfo(kClient2Id);
   // Check we can't get the shader after we remove it.
-  manager_.RemoveShaderInfo(kClient1Id);
+  manager_.MarkAsDeleted(info1);
   EXPECT_TRUE(manager_.GetShaderInfo(kClient1Id) == NULL);
 }
 
 TEST_F(ShaderManagerTest, Destroy) {
   const GLuint kClient1Id = 1;
   const GLuint kService1Id = 11;
   const GLenum kShader1Type = GL_VERTEX_SHADER;
   // Check we can create shader.
   manager_.CreateShaderInfo(kClient1Id, kService1Id, kShader1Type);
   // Check shader got created.
   ShaderManager::ShaderInfo* info1 = manager_.GetShaderInfo(kClient1Id);
   ASSERT_TRUE(info1 != NULL);
   EXPECT_CALL(*gl_, DeleteShader(kService1Id))
       .Times(1)
       .RetiresOnSaturation();
   manager_.Destroy(true);
   // Check that resources got freed.
   info1 = manager_.GetShaderInfo(kClient1Id);
   ASSERT_TRUE(info1 == NULL);
 }
 
+TEST_F(ShaderManagerTest, ShaderInfo) {
+  const GLuint kClient1Id = 1;
+  const GLuint kService1Id = 11;
+  const GLenum kShader1Type = GL_VERTEX_SHADER;
+  const std::string kClient1Source("hello world");
+  // Check we can create shader.
+  manager_.CreateShaderInfo(kClient1Id, kService1Id, kShader1Type);
+  // Check shader got created.
+  ShaderManager::ShaderInfo* info1 = manager_.GetShaderInfo(kClient1Id);
+  ASSERT_TRUE(info1 != NULL);
+  EXPECT_EQ(kService1Id, info1->service_id());
+  // Check if the shader has correct type.
+  EXPECT_EQ(kShader1Type, info1->shader_type());
+  EXPECT_FALSE(info1->IsValid());
+  EXPECT_FALSE(info1->InUse());
+  EXPECT_STREQ("", info1->log_info().c_str());
+  const char* kLog = "foo";
+  info1->SetStatus(true, kLog, NULL);
+  EXPECT_TRUE(info1->IsValid());
+  EXPECT_STREQ(kLog, info1->log_info().c_str());
+  // Check we can set its source.
+  info1->Update(kClient1Source);
+  EXPECT_STREQ(kClient1Source.c_str(), info1->source().c_str());
+}
+
 TEST_F(ShaderManagerTest, GetInfo) {
   const GLuint kClient1Id = 1;
   const GLuint kService1Id = 11;
   const GLenum kShader1Type = GL_VERTEX_SHADER;
   const GLenum kAttrib1Type = GL_FLOAT_VEC2;
   const GLsizei kAttrib1Size = 2;
   const char* kAttrib1Name = "attr1";
   const GLenum kAttrib2Type = GL_FLOAT_VEC3;
   const GLsizei kAttrib2Size = 4;
   const char* kAttrib2Name = "attr2";
@@ skipping 50 matching lines @@
     EXPECT_TRUE(variable_info == NULL);
   }
   for (ShaderTranslator::VariableMap::const_iterator it = uniform_map.begin();
        it != uniform_map.end(); ++it) {
     const ShaderManager::ShaderInfo::VariableInfo* variable_info =
         info1->GetUniformInfo(it->first);
     ASSERT_TRUE(variable_info == NULL);
   }
 }
 
+TEST_F(ShaderManagerTest, ShaderInfoUseCount) {
+  const GLuint kClient1Id = 1;
+  const GLuint kService1Id = 11;
+  const GLenum kShader1Type = GL_VERTEX_SHADER;
+  // Check we can create shader.
+  manager_.CreateShaderInfo(kClient1Id, kService1Id, kShader1Type);
+  // Check shader got created.
+  ShaderManager::ShaderInfo* info1 = manager_.GetShaderInfo(kClient1Id);
+  ASSERT_TRUE(info1 != NULL);
+  EXPECT_FALSE(info1->InUse());
+  EXPECT_FALSE(info1->IsDeleted());
+  manager_.UseShader(info1);
+  EXPECT_TRUE(info1->InUse());
+  manager_.UseShader(info1);
+  EXPECT_TRUE(info1->InUse());
+  manager_.MarkAsDeleted(info1);
+  EXPECT_TRUE(info1->IsDeleted());
+  ShaderManager::ShaderInfo* info2 = manager_.GetShaderInfo(kClient1Id);
+  EXPECT_EQ(info1, info2);
+  manager_.UnuseShader(info1);
+  EXPECT_TRUE(info1->InUse());
+  manager_.UnuseShader(info1);  // this should delete the info.
+  info2 = manager_.GetShaderInfo(kClient1Id);
+  EXPECT_TRUE(info2 == NULL);
+
+  manager_.CreateShaderInfo(kClient1Id, kService1Id, kShader1Type);
+  info1 = manager_.GetShaderInfo(kClient1Id);
+  ASSERT_TRUE(info1 != NULL);
+  EXPECT_FALSE(info1->InUse());
+  manager_.UseShader(info1);
+  EXPECT_TRUE(info1->InUse());
+  manager_.UseShader(info1);
+  EXPECT_TRUE(info1->InUse());
+  manager_.UnuseShader(info1);
+  EXPECT_TRUE(info1->InUse());
+  manager_.UnuseShader(info1);
+  EXPECT_FALSE(info1->InUse());
+  info2 = manager_.GetShaderInfo(kClient1Id);
+  EXPECT_EQ(info1, info2);
+  manager_.MarkAsDeleted(info1);  // this should delete the shader.
+  info2 = manager_.GetShaderInfo(kClient1Id);
+  EXPECT_TRUE(info2 == NULL);
+}
+
 }  // namespace gles2
 }  // namespace gpu