Make shader and program object lifetimes match OpenGL ES spec....

gpu/command_buffer/service/program_manager.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_COMMAND_BUFFER_SERVICE_PROGRAM_MANAGER_H_
 #define GPU_COMMAND_BUFFER_SERVICE_PROGRAM_MANAGER_H_
 
 #include <map>
 #include <string>
 #include <vector>
 #include "base/basictypes.h"
+#include "base/logging.h"
 #include "base/ref_counted.h"
 #include "gpu/command_buffer/service/gl_utils.h"
 #include "gpu/command_buffer/service/shader_manager.h"
 
 namespace gpu {
 namespace gles2 {
 
 // Tracks the Programs.
 //
 // NOTE: To support shared resources an instance of this class will
@@ skipping 101 matching lines @@
     bool IsDeleted() const {
       return service_id_ == 0;
     }
 
     void GetProgramiv(GLenum pname, GLint* params);
 
     bool IsValid() const {
       return valid_;
     }
 
-    bool AttachShader(ShaderManager::ShaderInfo* info);
-    void DetachShader(ShaderManager::ShaderInfo* info);
+    bool AttachShader(ShaderManager* manager, ShaderManager::ShaderInfo* info);
+    void DetachShader(ShaderManager* manager, ShaderManager::ShaderInfo* info);
 
     bool CanLink() const;
 
     const std::string& log_info() const {
       return log_info_;
     }
 
     void set_log_info(const std::string& str) {
       log_info_ = str;
     }
 
+    bool InUse() const {
+      DCHECK_GE(use_count_, 0);
+      return use_count_ != 0;
+    }
+
    private:
     friend class base::RefCounted<ProgramInfo>;
     friend class ProgramManager;
 
     ~ProgramInfo();
 
+    void IncUseCount() {
+      ++use_count_;
+    }
+
+    void DecUseCount() {
+      --use_count_;
+      DCHECK_GE(use_count_, 0);
+    }
+
     void MarkAsDeleted() {
+      DCHECK_NE(service_id_, 0u);
       service_id_ = 0;
     }
 
     const UniformInfo* AddUniformInfo(
         GLsizei size, GLenum type, GLint location, const std::string& name);
 
     void GetCorrectedVariableInfo(
         bool use_uniforms, const std::string& name, std::string* corrected_name,
         GLsizei* size, GLenum* type) const;
 
+    void DetachShaders(ShaderManager* manager);
+
+    int use_count_;
+
     GLsizei max_attrib_name_length_;
 
     // Attrib by index.
     AttribInfoVector attrib_infos_;
 
     // Attrib by location to index.
     std::vector<GLint> attrib_location_to_index_map_;
 
     GLsizei max_uniform_name_length_;
 
@@ skipping 24 matching lines @@
 
   // Must call before destruction.
   void Destroy(bool have_context);
 
   // Creates a new program info.
   void CreateProgramInfo(GLuint client_id, GLuint service_id);
 
   // Gets a program info
   ProgramInfo* GetProgramInfo(GLuint client_id);
 
-  // Deletes the program info for the given program.
-  void RemoveProgramInfo(GLuint client_id);
-
   // Gets a client id for a given service id.
   bool GetClientId(GLuint service_id, GLuint* client_id) const;
 
+  // Marks a program as deleted. If it is not used the info will be deleted.
+  void MarkAsDeleted(ShaderManager* shader_manager, ProgramInfo* info);
+
+  // Marks a program as used.
+  void UseProgram(ProgramInfo* info);
+
+  // Makes a program as unused. If deleted the program info will be removed.
+  void UnuseProgram(ShaderManager* shader_manager, ProgramInfo* info);
+
   // Returns true if prefix is invalid for gl.
   static bool IsInvalidPrefix(const char* name, size_t length);
 
  private:
   // Info for each "successfully linked" program by service side program Id.
   // TODO(gman): Choose a faster container.
   typedef std::map<GLuint, ProgramInfo::Ref> ProgramInfoMap;
   ProgramInfoMap program_infos_;
 
+  void RemoveProgramInfoIfUnused(
+      ShaderManager* shader_manager, ProgramInfo* info);
+
   DISALLOW_COPY_AND_ASSIGN(ProgramManager);
 };
 
 }  // namespace gles2
 }  // namespace gpu
 
 #endif  // GPU_COMMAND_BUFFER_SERVICE_PROGRAM_MANAGER_H_